RE: [RFC 12/17] irq: bypass: Extend skeleton for ARM forwarding control

Wu, Feng
2015-07-03T02:20:04Z

> -----Original Message-----
> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> Sent: Thursday, July 02, 2015 9:41 PM
> To: Eric Auger; eric.auger@st.com; linux-arm-kernel@lists.infradead.org;
> kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org;
> christoffer.dall@linaro.org; marc.zyngier@arm.com;
> alex.williamson@redhat.com; avi.kivity@gmail.com; mtosatti@redhat.com;
> Wu, Feng; joro@8bytes.org; b.reynal@virtualopensystems.com
> Cc: linux-kernel@vger.kernel.org; patches@linaro.org
> Subject: Re: [RFC 12/17] irq: bypass: Extend skeleton for ARM forwarding
> control
>
>
>
> On 02/07/2015 15:17, Eric Auger wrote:
> > - new fields are added on producer side: linux irq, vfio_device handle,
> > active which reflects whether the source is active (at interrupt
> > controller level or at VFIO level - automasked -) and finally an
> > opaque pointer which will be used to point to the vfio_platform_device
> > in this series.
>
> Linux IRQ and active should be okay. As to the vfio_device handle, you
> should link it from the vfio_platform_device instead. And for the
> vfio_platform_device, you can link it from the vfio_platform_irq instead.
>
> Once you've done this, embed the irq_bypass_producer struct in the
> vfio_platform_irq struct; in the new kvm_arch_* functions, go back to
> the vfio_platform_irq struct via container_of. From there you can
> retrieve pointers to the vfio_platform_device and the vfio_device.
>
> > - new fields on consumer side: the kvm handle, the gsi
>
> You do not need to add these. Instead, add the kvm handle to irqfd
> only. Like above, embed the irq_bypass_consumer struct in the irqfd
> struct; in the new kvm_arch_* functions, go back to the
> vfio_platform_irq struct via container_of.
>

I also need the gsi field here, for posted-interrupts, I need 'gsi', 'irq' to
update the IRTE.

Thanks,
Feng

> Paolo