From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbbGEJZM (ORCPT ); Sun, 5 Jul 2015 05:25:12 -0400 Received: from mout.web.de ([212.227.17.11]:63267 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751392AbbGEJZG (ORCPT ); Sun, 5 Jul 2015 05:25:06 -0400 Message-ID: <5597877E.3060503@users.sourceforge.net> Date: Sat, 04 Jul 2015 09:13:02 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ingo Molnar , Peter Zijlstra , LKML CC: kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] kernel-sched: Delete an unnecessary check before unregister_sysctl_table() References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:umjt29xeTO7blqeeuLMFdLxsSsVtCGhf/XBjm88HjZ3/elY303j gf2LQY3Ii3pUxo1T0gSBGolFzs61BwIkttcoJMeRwZfysR+wfdsiTCxcnfLlC2i7nJjbXDA PFuw8RTtPxPZsvKnZYnbpLAiQHURcsz9opR2qg8dCovGJxRl7WWqXi0ekNVJ+DMdB7uBtil re+tNeRF7zuizkg1Wd9TA== X-UI-Out-Filterresults: notjunk:1;V01:K0:F3N9Jm3Y9Hc=:zEg6ox43hsoANe9dLFDG0z CFv+PeY1uNBaBO1KwZxzPuCk2Ga+8MgU99D31/QOKUP71y5Bj9R5J5yaUozDpAsb4Jt+1+x+U NdJSuWq36NFUzdskTcoOvZc9ai+3ZWNsWToRBc/xFCRYrL/RJEJAT/Kkgkemy/bxcYjEnpBMy zPvokrzXnpWUkGIVBNIH/0cDW17KTL5S8R2ua8PqFRSQwetSFpHyd6OR2Ahih7aDENoDvAvfI yjV+cOjzQHqbkHa/uQnbJrg9pWbxZoTVVuT1NDP6ksNnfGSxfhklEx02s935NH9bsF7LG2dCH D6Lwi9jnM2B9mPLIbcpBOwpjbw3+j3cMB/j5MXblN1q/uxEFR7q9g/1s0drAJ46QOXVMBv15n oiAH77sIHWJXajmz0/nj+lypThn4ncy++AUJk3uGnbTolTC2UpLYJtBAzXfER1egaYPNKPnIt 8Bol0u7CZeIprLBm7qtlmclSoInfbyrBOkCM8PYDYphDJ8s5Wwmgui/t8MF18AadvSzGAc9jG O0xalFKdPTPdf3teZihli16SWrgsjktyoGL8V41bytUysILvEuJxr18j0wYthBlpM9WCUiwu3 QE9JVIlfArdnt+0kNNxP25kVWHrITF2gWDPIBycxSr3oKTyVEoTxgbVb4hTtkfalqJbcnmTfM 4KW5JDlvr6zNRmwVasYCDyo8uOFfAlsx0LcS49bJSNyk2TqBAxXQtArzmYXJQIUelxfc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 4 Jul 2015 09:06:32 +0200 The unregister_sysctl_table() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/sched/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index b803e1b..4756d1c 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5298,8 +5298,7 @@ static void register_sched_domain_sysctl(void) /* may be called multiple times per register */ static void unregister_sched_domain_sysctl(void) { - if (sd_sysctl_header) - unregister_sysctl_table(sd_sysctl_header); + unregister_sysctl_table(sd_sysctl_header); sd_sysctl_header = NULL; if (sd_ctl_dir[0].child) sd_free_ctl_entry(&sd_ctl_dir[0].child); -- 2.4.5