Re: [PATCH] vme: print unhandled VME access errors

[Martyn Welch <martyn.welch@ge.com>]

That's the ticket :-)

On 06/07/15 15:43, Dmitry Kalinkin wrote:
> This will enable error messages for accesses done through mmap.
>
> Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
> ---
> This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset.
> ---
>   drivers/vme/vme.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
> index 7a10d92..72924b0 100644
> --- a/drivers/vme/vme.c
> +++ b/drivers/vme/vme.c
> @@ -1028,6 +1028,7 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
>   {
>   	struct list_head *handler_pos = NULL;
>   	struct vme_error_handler *handler;
> +	int handler_triggered = 0;
>   	u32 aspace = vme_get_aspace(am);
>
>   	list_for_each(handler_pos, &bridge->vme_error_handlers) {
> @@ -1040,8 +1041,14 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
>   				handler->first_error = address;
>   			if (handler->num_errors != UINT_MAX)
>   				handler->num_errors++;
> +			handler_triggered = 1;
>   		}
>   	}
> +
> +	if (!handler_triggered)
> +		dev_err(bridge->parent,
> +			"Unhandled VME access error at address 0x%llx\n",
> +			address);
>   }
>   EXPORT_SYMBOL(vme_bus_error_handler);
>
>

-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@ge.com                  | VAT:GB 927559189