From: David Ahern <dsahern@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf record: Let user have timestamps with per-thread recording
Date: Mon, 06 Jul 2015 09:31:13 -0600 [thread overview]
Message-ID: <559A9F41.4050705@gmail.com> (raw)
In-Reply-To: <1436183461-1918-1-git-send-email-adrian.hunter@intel.com>
On 7/6/15 5:51 AM, Adrian Hunter wrote:
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 6be3c01ff6f8..ec98e5b4e14e 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -707,7 +707,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)
> */
> if (opts->sample_time &&
> (!perf_missing_features.sample_id_all &&
> - (!opts->no_inherit || target__has_cpu(&opts->target) || per_cpu)))
> + (!opts->no_inherit || target__has_cpu(&opts->target) || per_cpu ||
> + opts->sample_time_set)))
> perf_evsel__set_sample_bit(evsel, TIME);
>
> if (opts->raw_samples && !evsel->no_aux_samples) {
>
Why is the sample_time_set even needed? If a user or a command asks for
sample time the bit should be set. This seems crazy that underlying code
is ignoring the request.
next prev parent reply other threads:[~2015-07-06 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 11:51 [PATCH] perf record: Let user have timestamps with per-thread recording Adrian Hunter
2015-07-06 15:31 ` David Ahern [this message]
2015-07-07 7:32 ` Adrian Hunter
2015-07-06 16:33 ` [tip:perf/core] " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A9F41.4050705@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).