From: Sasha Levin <sasha.levin@oracle.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@kernel.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/asm/entry/64: Clean up entry_64.S
Date: Mon, 06 Jul 2015 13:34:28 -0400 [thread overview]
Message-ID: <559ABC24.8040300@oracle.com> (raw)
In-Reply-To: <CALCETrUNurOoDE7TXb3-Xnw-gx559c_q-Fe3qY6KyMCfdL2UDA@mail.gmail.com>
On 07/06/2015 01:20 PM, Andy Lutomirski wrote:
> On Mon, Jul 6, 2015 at 8:00 AM, Sasha Levin <sasha.levin@oracle.com> wrote:
>> >
>> > --- entry.before.o.cmd 2015-07-06 10:48:32.110189938 -0400
>> > +++ entry.after.o.cmd 2015-07-06 10:48:23.509645442 -0400
>> > @@ -1,5 +1,5 @@
>> >
>> > -entry.before.o: file format elf64-x86-64
>> > +entry.after.o: file format elf64-x86-64
>> >
>> >
>> > Disassembly of section .entry.text:
>> > @@ -3961,8 +3961,8 @@
>> > 3b: 09 02 or %eax,(%rdx)
>> > ...
>> > 3d: R_X86_64_64 .entry.text
>> > - 45: 03 3a add (%rdx),%edi
>> > - 47: 01 3d 03 d6 00 c8 add %edi,-0x37ff29fd(%rip) # ffffffffc800d650 <ignore_sysret+0xffffffffc800b1f0>
>> > + 45: 03 33 add (%rbx),%esi
>> > + 47: 01 3d 03 d5 00 c8 add %edi,-0x37ff2afd(%rip) # ffffffffc800d550 <ignore_sysret+0xffffffffc800b0f0>
> What exactly are you doing to generate this diff? This all looks really weird.
>
>> > 4d: 44 91 rex.R xchg %eax,%ecx
>> > 4f: 93 xchg %eax,%ebx
>> > 50: 2f (bad)
> For example: what on earth is the asm above?
objdump...
Thanks,
Sasha
next prev parent reply other threads:[~2015-07-06 17:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 8:34 [PATCH 0/4] x86: Untangle and standardize x86 system call entry point names Ingo Molnar
2015-06-08 8:34 ` [PATCH 1/4] x86/asm/entry: Rename compat syscall entry points Ingo Molnar
2015-06-08 8:47 ` Borislav Petkov
2015-06-08 8:34 ` [PATCH 2/4] x86/asm/entry: Untangle 'ia32_sysenter_target' into two entry points: entry_SYSENTER_32 and entry_SYSENTER_compat Ingo Molnar
2015-06-09 0:13 ` Andy Lutomirski
2015-06-09 9:33 ` Ingo Molnar
2015-06-09 16:33 ` Andy Lutomirski
2015-06-08 8:35 ` [PATCH 3/4] x86/asm/entry: Untangle 'system_call' into two entry points: entry_SYSCALL_64 and entry_INT80_32 Ingo Molnar
2015-06-08 8:35 ` [PATCH 4/4] x86/asm/entry/32: Clean up entry_32.S Ingo Molnar
2015-06-08 13:14 ` Denys Vlasenko
2015-06-08 18:51 ` [PATCH] x86/asm/entry/64: Clean up entry_64.S Ingo Molnar
2015-07-06 15:00 ` Sasha Levin
2015-07-06 16:07 ` Ingo Molnar
2015-07-06 16:19 ` Sasha Levin
2015-07-06 16:23 ` Ingo Molnar
2015-07-06 16:36 ` Sasha Levin
2015-07-06 16:43 ` Ingo Molnar
2015-07-06 17:02 ` Sasha Levin
2015-07-06 17:20 ` Andy Lutomirski
2015-07-06 17:34 ` Sasha Levin [this message]
2015-07-06 17:41 ` Ingo Molnar
2015-07-06 18:35 ` Andy Lutomirski
2015-07-06 18:39 ` Andy Lutomirski
2015-07-08 15:39 ` Sasha Levin
2015-07-07 7:01 ` Ingo Molnar
2015-07-09 0:59 ` Andy Lutomirski
2015-07-10 13:27 ` Sasha Levin
2015-07-10 15:26 ` Andrey Ryabinin
2015-07-10 15:36 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559ABC24.8040300@oracle.com \
--to=sasha.levin@oracle.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).