From: Jens Axboe <axboe@kernel.dk>
To: Maninder Singh <maninder1.s@samsung.com>, linux-kernel@vger.kernel.org
Cc: pankaj.m@samsung.com
Subject: Re: [PATCH 1/1] block: use FIELD_SIZEOF to calculate size of a field
Date: Tue, 07 Jul 2015 07:48:00 -0600 [thread overview]
Message-ID: <559BD890.107@kernel.dk> (raw)
In-Reply-To: <1436253067-22962-1-git-send-email-maninder1.s@samsung.com>
On 07/07/2015 01:11 AM, Maninder Singh wrote:
> use FIELD_SIZEOF instead of open coding
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
> block/blk-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 688ae94..5a9792e 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -3298,7 +3298,7 @@ EXPORT_SYMBOL(blk_post_runtime_resume);
> int __init blk_dev_init(void)
> {
> BUILD_BUG_ON(__REQ_NR_BITS > 8 *
> - sizeof(((struct request *)0)->cmd_flags));
> + FIELD_SIZEOF(struct request, cmd_flags));
>
> /* used for unplugging and affects IO latency/throughput - HIGHPRI */
> kblockd_workqueue = alloc_workqueue("kblockd",
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2015-07-07 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 7:11 [PATCH 1/1] block: use FIELD_SIZEOF to calculate size of a field Maninder Singh
2015-07-07 13:48 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559BD890.107@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox