From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757695AbbGHBfo (ORCPT ); Tue, 7 Jul 2015 21:35:44 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:32922 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752349AbbGHBfg (ORCPT ); Tue, 7 Jul 2015 21:35:36 -0400 Message-ID: <559C7E66.9040404@plumgrid.com> Date: Tue, 07 Jul 2015 18:35:34 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: He Kuang , rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com, acme@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org CC: wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 1/2] tracing: Add new trace type for bpf data output References: <1436269386-72037-1-git-send-email-hekuang@huawei.com> <1436269386-72037-2-git-send-email-hekuang@huawei.com> In-Reply-To: <1436269386-72037-2-git-send-email-hekuang@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/7/15 4:43 AM, He Kuang wrote: > + F_STRUCT( > + __field(long, size) as Peter said please use u32 to avoid 32 vs 64-bit issues. > + __array(u64, raw_data, TRACE_BPF_MAX_ENTRY) > + ), > + > + F_printk("%ld: (%016llx, ...)", __entry->size, __entry->raw_data[0]), can we conditionally print raw_data[0], raw_data[1], ..[3] when values are non-zero? '...' as part of print is kinda useless. Also I would drop '()' and ',' they don't add much value. Remember we won't be able to change this format once it goes in.