From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965024AbbGHI0T (ORCPT ); Wed, 8 Jul 2015 04:26:19 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:36096 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965010AbbGHIYq (ORCPT ); Wed, 8 Jul 2015 04:24:46 -0400 X-AuditID: cbfec7f5-f794b6d000001495-5f-559cde4bd64e Message-id: <559CDE4A.5090009@samsung.com> Date: Wed, 08 Jul 2015 17:24:42 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] ARM: dts: Include exynos5250-pinctrl after the nodes were defined References: <1436333790-18219-1-git-send-email-javier@osg.samsung.com> <1436333790-18219-2-git-send-email-javier@osg.samsung.com> In-reply-to: <1436333790-18219-2-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xy7re9+aEGjy9LW0x/8g5Vos3b9cw Wbx+YWjR//g1s8Wmx9dYLS7vmsNmMeP8PiYHdo9NqzrZPDYvqffY0n+X3aNvyypGj8+b5AJY o7hsUlJzMstSi/TtErgyfj5/w17QxFsx6+J6pgbGY1xdjJwcEgImEkdXTmKCsMUkLtxbz9bF yMUhJLCUUeLf6mesEM5TRonWP4/BqngFtCR2PD3KAmKzCKhK7Lj7hRHEZhMwlti8fAkbiC0q ECHx9vJJqHpBiR+T74HViwiEScxtPwg2lFmgnVHiT/ddVpCEsECMxM5719khtjUzSjy7uRys g1PAXeLJwtlARRxAHXoS9y9qgYSZBeQlNq95yzyBUWAWkh2zEKpmIalawMi8ilE0tTS5oDgp PddIrzgxt7g0L10vOT93EyMkxL/uYFx6zOoQowAHoxIPr0fMnFAh1sSy4srcQ4wSHMxKIry7 LgCFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwHjkxdEP rP0Wy+fozqxdxKN2Lb6Bf9PxXzr9BSdX3VEuTEsLUzkoKyB2wInvmZddCKNJF/eVTQfn8Ppp H0kU6mQ5XqEwKd2J5aNwWDPzonNXcnM+LTkSrC7gu+xSbPPTa2nPF1+cdtFA3+cPP7tNSrFL eBuvZLFlSS+rwf4NFtOf2XxnnbuTQ4mlOCPRUIu5qDgRAHcQ58ltAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.07.2015 14:36, Javier Martinez Canillas wrote: > The dtc compiler combines all the defined nodes that have the same path > so a device node definition can be in one file and later be extended in > another one. > > That's the case of the Exynos5250 pinctrl device nodes that are defined > in the exynos5250.dtsi file and extended in exynos5250-pinctrl.dtsi. > > But since the exynos5250.dtsi file includes the exynos5250-pinctrl.dtsi > before the pinctrl device nodes are actually defined, the definition of > the pinctrl device nodes happens in exynos5250-pinctrl.dtsi and are > extended in exynos5250.dtsi. > > That is the opposite of the original intention so even when there is no > difference in practice, the exynos5250-pinctrl.dtsi include should be > moved at the end of the exynos5250.dtsi file after the pinctrl device > nodes have been already defined. > > This will also allow to later change the exynos5250-pinctrl.dtsi file > to use labels instead of full paths to extend the pinctrl nodes. Since > keeping the include at the top, would cause a dtc build error due the > pinctrl labels not being defined yet. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5250.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Yeah, I stomped on this too. I left it as is because it is more natural to have all includes at the beginning... but DTSI for Exynos3250 and 4415 already follow such convention and extending by labels is nice too, so overall I agree: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof