From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935315AbbGHI2K (ORCPT ); Wed, 8 Jul 2015 04:28:10 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:40470 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934667AbbGHIZK (ORCPT ); Wed, 8 Jul 2015 04:25:10 -0400 X-AuditID: cbfec7f5-f794b6d000001495-c6-559cde63f3f8 Message-id: <559CDE61.2040804@samsung.com> Date: Wed, 08 Jul 2015 17:25:05 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: dts: Include exynos5420-pinctrl after the nodes were defined References: <1436333790-18219-1-git-send-email-javier@osg.samsung.com> <1436333790-18219-4-git-send-email-javier@osg.samsung.com> In-reply-to: <1436333790-18219-4-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xy7rJ9+aEGkz8IG4x/8g5Vos3b9cw Wbx+YWjR//g1s8Wmx9dYLS7vmsNmMeP8PiYHdo9NqzrZPDYvqffY0n+X3aNvyypGj8+b5AJY o7hsUlJzMstSi/TtErgyLp6+zV4whbvi6oPlrA2MHZxdjJwcEgImEgsWP2GHsMUkLtxbz9bF yMUhJLCUUWLbrQvsEM5TRomVZ/ewgFTxCmhJLJi8BcxmEVCV2HXiIpjNJmAssXn5EjYQW1Qg QuLt5ZNMEPWCEj8m3wOrEREIk5jbfpAVZCizQDujxJ/uu6wgCWGBGIkF984xQmxrZpS4s/YQ WAengLvE881ngBIcQB16EvcvaoGEmQXkJTavecs8gVFgFpIdsxCqZiGpWsDIvIpRNLU0uaA4 KT3XSK84Mbe4NC9dLzk/dxMjJMS/7mBceszqEKMAB6MSD69HzJxQIdbEsuLK3EOMEhzMSiK8 uy4AhXhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REggPbEkNTs1tSC1CCbLxMEp1cDocSc6 4+gqGZmFDu53pgUe7tLLXObzW2vS7Ck6B6K1Wm+m23a+++ptp86Q5plt6+jx4vrq15EMt/3l joeoXvW7xn1btau7gd3ryOtbK+vV9O8xCtc2GCeu/OBeXxmnp2XGnd6hIhyTveWLx2mjlK2C HHd/3GX/wHjXzbB6DufXmW8yqworLiuxFGckGmoxFxUnAgBfogh/bQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.07.2015 14:36, Javier Martinez Canillas wrote: > The dtc compiler combines all the defined nodes that have the same path > so a device node definition can be in one file and later be extended in > another one. > > That's the case of the Exynos5420 pinctrl device nodes that are defined > in the exynos5420.dtsi file and extended in exynos5420-pinctrl.dtsi. > > But since the exynos5420.dtsi file includes the exynos5420-pinctrl.dtsi > before the pinctrl device nodes are actually defined, the definition of > the pinctrl device nodes happens in exynos5420-pinctrl.dtsi and are > extended in exynos5420.dtsi. > > That is the opposite of the original intention so even when there is no > difference in practice, the exynos5420-pinctrl.dtsi include should be > moved at the end of the exynos5420.dtsi file after the pinctrl device > nodes have been already defined. > > This will also allow to later change the exynos5420-pinctrl.dtsi file > to use labels instead of full paths to extend the pinctrl nodes. Since > keeping the include at the top, would cause a dtc build error due the > pinctrl labels not being defined yet. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5420.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof