From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935367AbbGHIaA (ORCPT ); Wed, 8 Jul 2015 04:30:00 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:40727 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934733AbbGHI3a (ORCPT ); Wed, 8 Jul 2015 04:29:30 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-e7-559cdf680148 Message-id: <559CDF66.6080609@samsung.com> Date: Wed, 08 Jul 2015 17:29:26 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths References: <1436333790-18219-1-git-send-email-javier@osg.samsung.com> <1436333790-18219-3-git-send-email-javier@osg.samsung.com> In-reply-to: <1436333790-18219-3-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xy7oZ9+eEGnxdoGYx/8g5Vos3b9cw Wbx+YWjR//g1s8Wmx9dYLS7vmsNmMeP8PiYHdo9NqzrZPDYvqffY0n+X3aNvyypGj8+b5AJY o7hsUlJzMstSi/TtErgyfrbtYCxYxlHx7cYnxgbGS2xdjJwcEgImEq3T7rBD2GISF+6tB4pz cQgJLGWUuPdzNzOE85RR4vqbVkaQKl4BLYnr71YzgdgsAqoSy+e9Zwax2QSMJTYvXwI2VVQg QuLt5ZNMEPWCEj8m32MBsUUEwiTmth9kBRnKLNDOKPGn+y4rSEJYIEniwc/HjBDbmhklzj5q AevgFHCXWHu3CSjBAdShJ3H/ohZImFlAXmLzmrfMExgFZiHZMQuhahaSqgWMzKsYRVNLkwuK k9JzDfWKE3OLS/PS9ZLzczcxQkL8yw7GxcesDjEKcDAq8fB6xMwJFWJNLCuuzD3EKMHBrCTC u+sCUIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv3F3vQ4QE0hNLUrNTUwtSi2CyTBycUg2M08TX ceitfR3mqrXr/SyOW8vKRY8YN3zhzzbrcPm3cXt2rcn7krS7U7LEbbcEvX16WqvJOuVrh3IM e9P8aS2hLN8+V3/9pn6pI/bpDoac4j1iV704bzSxhC9y1GKR8ooP+9vzZLpM52nODU+ll63a ecjjTHaK9axcu6SsePeNP1Y1c/+bzsulxFKckWioxVxUnAgAJqf8gG0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.07.2015 14:36, Javier Martinez Canillas wrote: > A previously defined Device Tree node, can be extended either by defining > a node using the same full path or by creating a label for the node and > referencing to it. > > Using full paths is more error prone since if there was a typo error, a > new node will be created instead of extending the node as it was desired. > This will lead to run-time errors that could be hard to detect. > > A misstyped label on the other hand, will cause a dtc compile error which s/misstyped/mistyped/ > makes it easier to detect the mistake since happens at build-time instead. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 1600 ++++++++++++++--------------- > 1 file changed, 799 insertions(+), 801 deletions(-) > I didn't look carefully enough to call it a review (I trust the 'diff' of yours) but it seems fine to me: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof