From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934126AbbGHNG5 (ORCPT ); Wed, 8 Jul 2015 09:06:57 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:33637 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758777AbbGHNGx (ORCPT ); Wed, 8 Jul 2015 09:06:53 -0400 Subject: Re: [PATCH v3 4/9] usb: dwc3: core: Adapt to named interrupts To: Roger Quadros , balbi@ti.com References: <1436351524-28385-1-git-send-email-rogerq@ti.com> <1436351795-28556-1-git-send-email-rogerq@ti.com> Cc: tony@atomide.com, Joao.Pinto@synopsys.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org From: Sergei Shtylyov Message-ID: <559D2068.90208@cogentembedded.com> Date: Wed, 8 Jul 2015 16:06:48 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1436351795-28556-1-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 7/8/2015 1:36 PM, Roger Quadros wrote: > From: Felipe Balbi > Add support to use interrupt names, > Following are the interrupt names > Peripheral Interrupt - peripheral > HOST Interrupt - host > OTG Interrupt - otg > [Roger Q] > - If any of these are missing we use the > first available IRQ resource so that we don't > break with older DTBs. > - Use gadget_irq in gadget driver. > Signed-off-by: Felipe Balbi > Signed-off-by: Roger Quadros > --- > drivers/usb/dwc3/core.c | 12 ++++++++++++ > drivers/usb/dwc3/core.h | 7 +++++++ > drivers/usb/dwc3/gadget.c | 2 +- > 3 files changed, 20 insertions(+), 1 deletion(-) > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index a7498e0..7b33d7b 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -941,6 +941,18 @@ static int dwc3_probe(struct platform_device *pdev) > dwc->xhci_resources[1].flags = res->flags; > dwc->xhci_resources[1].name = res->name; > > + dwc->otg_irq = platform_get_irq_byname(pdev, "otg"); > + if (!dwc->otg_irq) The usual mistake repeated again: that function reutrns error # on failure, not 0. > + dwc->otg_irq = res->start; > + > + dwc->gadget_irq = platform_get_irq_byname(pdev, "peripheral"); > + if (!dwc->gadget_irq) > + dwc->gadget_irq = res->start; Likewise. > + > + dwc->xhci_irq = platform_get_irq_byname(pdev, "host"); > + if (!dwc->xhci_irq) Likewise. [...] WBR, Sergei