From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH V3 1/4] perf: Add PERF_RECORD_SWITCH to indicate context switches
Date: Wed, 08 Jul 2015 16:42:03 +0300 [thread overview]
Message-ID: <559D28AB.4080201@intel.com> (raw)
In-Reply-To: <20150708132805.GC3243@kernel.org>
On 08/07/15 16:28, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 08, 2015 at 12:52:40AM +0200, Peter Zijlstra escreveu:
>> On Tue, Jul 07, 2015 at 01:13:59PM -0300, Arnaldo Carvalho de Melo wrote:
>>> Em Tue, Jul 07, 2015 at 05:36:14PM +0200, Peter Zijlstra escreveu:
>>>>> To help userspace in places where all it has is the union perf_event, we
>>>>> can reuse one bit in misc to state that, i.e.
>
>>>>> #define PERF_RECORD_MISC_SWITCH_NEXT_PREV_PID 14
>
>>>>> For instance.
>
>>>> The other option would be a separate RECORD type, which might be
>>>> simpler.
>
>>> Humm, do we really need it?
>
>>> I think this is just us wanting to, since we are going to add a new
>>> record, to make it more useful for other, not right now needed,
>>> situations, i.e. if the user is priviledged, there are two other options
>>> to get his info, right?
>
>> I was just thinking that 2 records, each with a fixed layout would be
>> easier to parse than 1 record with variable layout.
>
>> The record space is immense, so from that point it really doesn't
>> matter.
>
> We could do a land grab at some point there, if/when we find some reason
> for that... :-)
>
>> Do whatever is easiest, less mistakes get made etc. :-)
>
>> No real preference either way, as long we we've thought about it.
>
> Right, I just don't want to have two u32 carrying -1 for no reason.
So you'd be OK with 2 RECORD types?
I will see what is involved.
next prev parent reply other threads:[~2015-07-08 13:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 8:36 [PATCH V3 0/4] perf: Add PERF_RECORD_SWITCH to indicate context switches Adrian Hunter
2015-07-07 8:36 ` [PATCH V3 1/4] " Adrian Hunter
2015-07-07 13:25 ` Arnaldo Carvalho de Melo
2015-07-07 13:44 ` Arnaldo Carvalho de Melo
2015-07-07 15:36 ` Peter Zijlstra
2015-07-07 16:13 ` Arnaldo Carvalho de Melo
2015-07-07 22:52 ` Peter Zijlstra
2015-07-08 13:28 ` Arnaldo Carvalho de Melo
2015-07-08 13:42 ` Adrian Hunter [this message]
2015-07-08 14:56 ` Arnaldo Carvalho de Melo
2015-07-07 8:36 ` [PATCH V3 2/4] perf tools: Add new PERF_RECORD_SWITCH event Adrian Hunter
2015-07-07 13:50 ` Arnaldo Carvalho de Melo
2015-07-07 8:36 ` [PATCH V3 3/4] perf record: Add option --switch-events to select PERF_RECORD_SWITCH events Adrian Hunter
2015-07-07 13:53 ` Arnaldo Carvalho de Melo
2015-07-07 8:36 ` [PATCH V3 4/4] perf script: Add option --show-switch-events Adrian Hunter
2015-07-07 13:54 ` Arnaldo Carvalho de Melo
2015-07-07 9:06 ` [PATCH V3 0/4] perf: Add PERF_RECORD_SWITCH to indicate context switches Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559D28AB.4080201@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=pawel.moll@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).