From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934010AbbGHOpJ (ORCPT ); Wed, 8 Jul 2015 10:45:09 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:34080 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933793AbbGHOpG (ORCPT ); Wed, 8 Jul 2015 10:45:06 -0400 Message-ID: <559D3769.7020909@ti.com> Date: Wed, 8 Jul 2015 17:44:57 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sergei Shtylyov , CC: , , , , Subject: Re: [PATCH v3 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role References: <1436351524-28385-1-git-send-email-rogerq@ti.com> <1436351860-28813-1-git-send-email-rogerq@ti.com> <559D217B.5000500@cogentembedded.com> In-Reply-To: <559D217B.5000500@cogentembedded.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/15 16:11, Sergei Shtylyov wrote: > Hello. > > On 7/8/2015 1:37 PM, Roger Quadros wrote: > >> We can't rely just on dr_mode to decide if we're in host or gadget >> mode when we're configured as otg/dual-role. So while dr_mode is >> OTG, we find out from the otg state machine if we're in host >> or gadget mode and take the necessary actions during suspend/resume. > >> Also make sure that we disable OTG irq and events during system suspend >> so that we don't lockup the system during system suspend/resume. > >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/dwc3/core.c | 27 +++++++++------------------ >> 1 file changed, 9 insertions(+), 18 deletions(-) > >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >> index e3c094d..3784287 100644 >> --- a/drivers/usb/dwc3/core.c >> +++ b/drivers/usb/dwc3/core.c >> @@ -1444,18 +1444,15 @@ static int dwc3_suspend(struct device *dev) >> dwc->octl = dwc3_readl(dwc->regs, DWC3_OCTL); >> dwc->oevt = dwc3_readl(dwc->regs, DWC3_OEVT); >> dwc->oevten = dwc3_readl(dwc->regs, DWC3_OEVTEN); >> + dwc3_writel(dwc->regs, DWC3_OEVTEN, 0); >> + disable_irq(dwc->otg_irq); >> } >> >> - switch (dwc->dr_mode) { >> - case USB_DR_MODE_PERIPHERAL: >> - case USB_DR_MODE_OTG: >> + if (dwc->dr_mode == USB_DR_MODE_PERIPHERAL || >> + ((dwc->dr_mode == USB_DR_MODE_OTG) && dwc->fsm->protocol == PROTO_GADGET)) > > Hum, enclosing the first == op into parens and not doing it to the second == op doesn't look very consistent... :-) Agreed :). Will fix it. Thanks. > > [...] >> @@ -1495,18 +1492,12 @@ static int dwc3_resume(struct device *dev) >> dwc3_writel(dwc->regs, DWC3_OCTL, dwc->octl); >> dwc3_writel(dwc->regs, DWC3_OEVT, dwc->oevt); >> dwc3_writel(dwc->regs, DWC3_OEVTEN, dwc->oevten); >> + enable_irq(dwc->otg_irq); >> } >> >> - switch (dwc->dr_mode) { >> - case USB_DR_MODE_PERIPHERAL: >> - case USB_DR_MODE_OTG: >> + if (dwc->dr_mode == USB_DR_MODE_PERIPHERAL || >> + ((dwc->dr_mode == USB_DR_MODE_OTG) && dwc->fsm->protocol == PROTO_GADGET)) > > Same here... OK. > > [...] > cheers, -roger