From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758497AbbGHPIh (ORCPT ); Wed, 8 Jul 2015 11:08:37 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:48243 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749AbbGHPIe (ORCPT ); Wed, 8 Jul 2015 11:08:34 -0400 Message-ID: <559D3CEF.3070307@roeck-us.net> Date: Wed, 08 Jul 2015 08:08:31 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andrew Lunn CC: "David S. Miller" , netdev@vger.kernel.org, Florian Fainelli , linux-kernel@vger.kernel.org, "Aleksey S. Kazantsev" Subject: Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321 References: <1436326695-18666-1-git-send-email-linux@roeck-us.net> <20150708145234.GB32208@lunn.ch> In-Reply-To: <20150708145234.GB32208@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2015 07:52 AM, Andrew Lunn wrote: > On Tue, Jul 07, 2015 at 08:38:15PM -0700, Guenter Roeck wrote: >> From: "Aleksey S. Kazantsev" >> >> MV88E6320 and MV88E6321 are largely compatible to MV886352, >> but are members of a different chip family. >> >> Signed-off-by: Aleksey S. Kazantsev >> Signed-off-by: Guenter Roeck > > Reviewed-by: Andrew Lunn > > One thing we might want to consider, is moving the temperate sensor > code into mv88e6xxx. It seems likely future devices will also have the > same sensor, so moving it to the shared code would make sense. We can > then keep all mv88e6xxx_XXXX_family() stuff in a single file. > > I don't see this as a blocker for this patchset, but now might be the > right time to do this. > Makes sense. Let's do it in a separate patch, though. I'll do that in a couple of weeks, after I am back from vacation. Thanks, Guenter