From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758723AbbGHTcK (ORCPT ); Wed, 8 Jul 2015 15:32:10 -0400 Received: from mout.web.de ([212.227.15.3]:50378 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbbGHTcE (ORCPT ); Wed, 8 Jul 2015 15:32:04 -0400 Subject: [PATCH] ALSA: hda: Delete an unnecessary check before the function call "kobject_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <559D7AAD.8020500@users.sourceforge.net> Date: Wed, 8 Jul 2015 21:31:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:U36ATZrINzMVmTNRwHzscp5MFmIaftJcpY7HjxFAxUWhuzXO1LU bQpdxl7q6ZsFitLzvXMb3IHlcndYJg3DW+SbEoVfKN41O0PMSNp5LJSrGB4CglahqPCQbo2 9RLX50qHBmDjNq9DfPUklcnGSuxlCtg/ApA2TaUxLLMkqkgT2Vx0daxujGySg48L3rHW2FA qaZUAzEkfVwpk41PR4WHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Pt+QFgqbz94=:wJAEW3MgE+8/BjPbMFb5Hn 9S6fv2nBBYjVr7YtbPVlui7fPULloCaRTnLCZA47mnR/62WCHhZkp97Cf3sxfHK7Dl5S4Wg4m OgWZQ2ekqE4g2sgP2iIFyKe9Gj2/dF8ZK0lOGA/x9Z01jGQEQFv++9FnhOgsI2qAT2vmq0Egg R2lw3FAs7OKUAVtAvzbUPjjWuvpQVf6cbpBvggx1YmOec8yUSP1qh+rjqGz/bKANiA9G4OiTe zC+/9m7HgMN6JicQc8NFTPkWqcQHZQElX2aAbdvaqO3dSFduutCaeP/1gYVDMwekk8jV1DJww wyNHrJsF4iQ8Y6LSi0HNyuwhKdkYVecdhn936p9kfSmcAtlUcCreEBogot8nYoh2ixRljCean uo4lEuLMlWV19DBtJV6cGfvLcJkkl0dKikqK3Dxho6U5pwEm9ewVuIHU28JZ3ykuSkbt1ArjJ QHgj/YZtPnWoP8twGRCTBSFtPOszPEWy8DyP07m+w0Y/IFExXS64d+omL83oW2hjg0DZScjL2 6K3PUW4fY4ew/ClZ+RNx5POcUZu5ezOq9WqR/MCr/2yYoxbttKQm1gXDAE6yyAHOmOtvXxWdX rfMGRzvzDIrQXcOQZS5XBsH3NezfWAN1sI+SLwwB/ZF5Ecvkubf1BZZ7iVTwppRjK1ZnGu6vD /5MATtCCe+BZSVoq1TM7103U16GkRVes2rxqOFrQ3q7BrO4avN5n3UxN+W2ixxGw3q+w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 8 Jul 2015 21:26:02 +0200 The kobject_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/hda/hdac_sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/hda/hdac_sysfs.c b/sound/hda/hdac_sysfs.c index 0a6ce3b..089b35f 100644 --- a/sound/hda/hdac_sysfs.c +++ b/sound/hda/hdac_sysfs.c @@ -321,8 +321,7 @@ static void widget_tree_free(struct hdac_device *codec) free_widget_node(*p, &widget_node_group); kfree(tree->nodes); } - if (tree->root) - kobject_put(tree->root); + kobject_put(tree->root); kfree(tree); codec->widgets = NULL; } -- 2.4.5