* Re: [PATCH] jffs2:Fix error paths return value for the function read_unknown
[not found] <1436389195-16522-1-git-send-email-xerofoify@gmail.com>
@ 2015-07-08 21:20 ` Richard Weinberger
[not found] ` <559D943B.1030708@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2015-07-08 21:20 UTC (permalink / raw)
To: Nicholas Krause; +Cc: David Woodhouse, linux-mtd@lists.infradead.org, LKML
On Wed, Jul 8, 2015 at 10:59 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This fixes the error paths in the function read_unknown that return
> a value to correctly return -EIO rather then the kernel value for
> successful function execution of zero to indicate to this function's
> callers that a failure has occurred related to I/O and needs to be
> handled by this function's caller.
Did you test this patch?
I guess not.
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jffs2:Fix error paths return value for the function read_unknown
[not found] ` <559D943B.1030708@gmail.com>
@ 2015-07-08 21:27 ` Richard Weinberger
2015-07-08 21:28 ` Richard Weinberger
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2015-07-08 21:27 UTC (permalink / raw)
To: nick; +Cc: David Woodhouse, linux-mtd@lists.infradead.org, LKML
Am 08.07.2015 um 23:20 schrieb nick:
>
>
> On 2015-07-08 05:20 PM, Richard Weinberger wrote:
>> On Wed, Jul 8, 2015 at 10:59 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
>>> This fixes the error paths in the function read_unknown that return
>>> a value to correctly return -EIO rather then the kernel value for
>>> successful function execution of zero to indicate to this function's
>>> callers that a failure has occurred related to I/O and needs to be
>>> handled by this function's caller.
>>
>> Did you test this patch?
>> I guess not.
>>
> No I don't have hardware why?
It is broken.
Both paths are not fatal errors and the soft error
is already handled by calling jffs2_mark_node_obsolete().
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jffs2:Fix error paths return value for the function read_unknown
[not found] ` <559D943B.1030708@gmail.com>
2015-07-08 21:27 ` Richard Weinberger
@ 2015-07-08 21:28 ` Richard Weinberger
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2015-07-08 21:28 UTC (permalink / raw)
To: nick; +Cc: David Woodhouse, linux-mtd@lists.infradead.org, LKML
>> On Wed, Jul 8, 2015 at 10:59 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
Oh, damn. I should have stopped reading here. /ignore.
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-08 21:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1436389195-16522-1-git-send-email-xerofoify@gmail.com>
2015-07-08 21:20 ` [PATCH] jffs2:Fix error paths return value for the function read_unknown Richard Weinberger
[not found] ` <559D943B.1030708@gmail.com>
2015-07-08 21:27 ` Richard Weinberger
2015-07-08 21:28 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox