From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759010AbbGHV1W (ORCPT ); Wed, 8 Jul 2015 17:27:22 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758230AbbGHV1N (ORCPT ); Wed, 8 Jul 2015 17:27:13 -0400 Message-ID: <559D95AF.8060500@nod.at> Date: Wed, 08 Jul 2015 23:27:11 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: nick CC: David Woodhouse , "linux-mtd@lists.infradead.org" , LKML Subject: Re: [PATCH] jffs2:Fix error paths return value for the function read_unknown References: <1436389195-16522-1-git-send-email-xerofoify@gmail.com> <559D943B.1030708@gmail.com> In-Reply-To: <559D943B.1030708@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 08.07.2015 um 23:20 schrieb nick: > > > On 2015-07-08 05:20 PM, Richard Weinberger wrote: >> On Wed, Jul 8, 2015 at 10:59 PM, Nicholas Krause wrote: >>> This fixes the error paths in the function read_unknown that return >>> a value to correctly return -EIO rather then the kernel value for >>> successful function execution of zero to indicate to this function's >>> callers that a failure has occurred related to I/O and needs to be >>> handled by this function's caller. >> >> Did you test this patch? >> I guess not. >> > No I don't have hardware why? It is broken. Both paths are not fatal errors and the soft error is already handled by calling jffs2_mark_node_obsolete(). Thanks, //richard