From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153AbbGHXwC (ORCPT ); Wed, 8 Jul 2015 19:52:02 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:11999 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbbGHXvy (ORCPT ); Wed, 8 Jul 2015 19:51:54 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-8c-559db797a749 Message-id: <559DB799.3040800@samsung.com> Date: Thu, 09 Jul 2015 08:51:53 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes References: <1436333790-18219-1-git-send-email-javier@osg.samsung.com> <559CDEDA.50608@samsung.com> <559D308E.3020809@osg.samsung.com> In-reply-to: <559D308E.3020809@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsVy+t/xK7rTt88NNZi8Wc1i/pFzrBZv3q5h snj9wtCi//FrZotNj6+xWlzeNYfNYsb5fUwO7B6bVnWyeWxeUu+xpf8uu0ffllWMHp83yQWw RnHZpKTmZJalFunbJXBlfD79nK1gKVfFtTnZDYyzOLoYOTkkBEwkJq2ayw5hi0lcuLeerYuR i0NIYCmjxMk1L5khnKeMEnf/PWMCqeIV0JI49fYoC4jNIqAq8WLyQmYQm03AWGLz8iVsILao QITE28snoeoFJX5MvgdWLyIQJjG3/SAryFBmgXZGiT/dd1lBEsIC8RL3L92C2tbBKLHjzA+w bk4BfYnpJ2YCFXEAdehJ3L+oBRJmFpCX2LzmLfMERoFZSHbMQqiahaRqASPzKkbR1NLkguKk 9FxDveLE3OLSvHS95PzcTYyQAP+yg3HxMatDjAIcjEo8vB4xc0KFWBPLiitzDzFKcDArifBq rJwbKsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQZGn/xg xSM9oVHLVrDOZNGReN925X+X4yQp720M1T5RGqI3ncrPrV38Q9xpq1bS6/jEM3f/Bty56Xam 7nl+5bQcpsy3qYnKn3I51ia826SjfZ5NYXfO/kKV7kXBBhtXr1105VBM876VLU6bq/yfr7t3 +PyRon+CvyqTmffssru9YNs73lcn3rZIKbEUZyQaajEXFScCACeUXPZsAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.07.2015 23:15, Javier Martinez Canillas wrote: > Krzysztof, > > On 07/08/2015 01:27 AM, Krzysztof Kozlowski wrote: >> On 08.07.2015 14:36, Javier Martinez Canillas wrote: >>> Hello Kukjin and Krzysztof, >>> >>> This is a trivial series that changes Exynos5 pinctrl dtsi files to extend >>> the pinctrl nodes using labels instead of full paths. >>> >>> Using labels is less error prone since a misstyped label leads to a build >>> error while full paths can lead to the creation of a new node instead of >>> overriding the original which makes the mistake harder to detect. >>> >>> I tested the changes by decompiling the Exynos5* dtbs and comparing before >>> and after. The resulting dts were identical modulo some node ordering due >>> the pinctrl include change. >> >> Is the DTB before and after the same? It should not change by re-ordering. >> > > The DTB differ but I'm not that familiar with how dtc represents the FDT > to know what is changing in the binary. > > But as mentioned, the decompiled DTS only changes in which position the > pinctrl are defined and both DTS are identical if I do: > > $ cat decompiled.dts | sort Right, the DTB may differ because of change of definition's location. If sorting fixes this then I'm convinced. Best regards, Krzysztof