Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

Greg KH
2015-06-30T23:48:10Z

On Tue, Jun 30, 2015 at 04:44:10PM -0500, Jeremy White wrote:
> This module uses the usbredir protocol and user space tools,
> which are used by the SPICE project.
>
> Signed-off-by: Jeremy White <jwhite@codeweavers.com>
> ---
> MAINTAINERS | 6 +
> drivers/usb/Kconfig | 2 +
> drivers/usb/Makefile | 1 +
> drivers/usb/usbredir/Kconfig | 25 +
> drivers/usb/usbredir/Makefile | 4 +
> drivers/usb/usbredir/README | 20 +
> drivers/usb/usbredir/TODO | 12 +
> drivers/usb/usbredir/device.c | 327 +++++
> drivers/usb/usbredir/hub.c | 489 ++++++++
> drivers/usb/usbredir/main.c | 100 ++
> drivers/usb/usbredir/redir.c | 535 ++++++++
> drivers/usb/usbredir/rx.c | 40 +
> drivers/usb/usbredir/strtok_r.c | 69 +
> drivers/usb/usbredir/strtok_r.h | 26 +
> drivers/usb/usbredir/sysfs.c | 145 +++
> drivers/usb/usbredir/tx.c | 151 +++
> drivers/usb/usbredir/urb.c | 266 ++++
> drivers/usb/usbredir/usbredir.h | 225 ++++
> drivers/usb/usbredir/usbredirfilter.c | 294 +++++
> drivers/usb/usbredir/usbredirfilter.h | 144 +++
> drivers/usb/usbredir/usbredirparser.c | 1795 +++++++++++++++++++++++++++
> drivers/usb/usbredir/usbredirparser.h | 386 ++++++
> drivers/usb/usbredir/usbredirproto-compat.h | 88 ++
> drivers/usb/usbredir/usbredirproto.h | 309 +++++
> 24 files changed, 5459 insertions(+)
> create mode 100644 drivers/usb/usbredir/Kconfig
> create mode 100644 drivers/usb/usbredir/Makefile
> create mode 100644 drivers/usb/usbredir/README
> create mode 100644 drivers/usb/usbredir/TODO
> create mode 100644 drivers/usb/usbredir/device.c
> create mode 100644 drivers/usb/usbredir/hub.c
> create mode 100644 drivers/usb/usbredir/main.c
> create mode 100644 drivers/usb/usbredir/redir.c
> create mode 100644 drivers/usb/usbredir/rx.c
> create mode 100644 drivers/usb/usbredir/strtok_r.c
> create mode 100644 drivers/usb/usbredir/strtok_r.h
> create mode 100644 drivers/usb/usbredir/sysfs.c
> create mode 100644 drivers/usb/usbredir/tx.c
> create mode 100644 drivers/usb/usbredir/urb.c
> create mode 100644 drivers/usb/usbredir/usbredir.h
> create mode 100644 drivers/usb/usbredir/usbredirfilter.c
> create mode 100644 drivers/usb/usbredir/usbredirfilter.h
> create mode 100644 drivers/usb/usbredir/usbredirparser.c
> create mode 100644 drivers/usb/usbredir/usbredirparser.h
> create mode 100644 drivers/usb/usbredir/usbredirproto-compat.h
> create mode 100644 drivers/usb/usbredir/usbredirproto.h

It's pointless to post a patch that you know has problems with it (i.e.
it's not even in proper kernel coding style), as it will never be
reviewed or even looked at.

Please do the most basic of polite things and fix this up before posting
things.

And really, all in one patch? That too is pretty hard to review...

thanks,

greg k-h