linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Andy Lutomirski <luto@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Oleg Nesterov <oleg@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Austin S Hemmelgarn <ahferroin7@gmail.com>,
	Brian Gerst <brgerst@gmail.com>,
	Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT
Date: Thu, 09 Jul 2015 11:51:03 -0700	[thread overview]
Message-ID: <559EC297.3030901@linux.intel.com> (raw)
In-Reply-To: <dae7c0f1282a92e5eeac8b9fc389e2a02051d9cb.1436467147.git.luto@kernel.org>

On 7/9/2015 11:40 AM, Andy Lutomirski wrote:
> VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is
> in use.  The code is a big undocumented mess, it's a real PITA to
> test, and it looks like a big chunk of vm86_32.c is dead code.  It
> also plays awful games with the entry asm.
>
> No one should be using it anyway.  Use DOSBOX or KVM instead.
>
> Let's accelerate its slow death.  Remove it from EXPERT and default
> it to n.  Distros should not enable it.  In the unlikely event that
> some user needs it, they can easily re-enable it.
>
> I've confirmed that 'make oldconfig' will set leave it set to y, so
> there should be little or no unexpected breakage from this change.
>

I would rather do BOTH the default n AND the EXPERT

e.g. the existing hurdle of EXPERT combined with the default
(e.g. off entirely in non-EXPERT, and with EXPERT it is sill defaulting to =n)



  parent reply	other threads:[~2015-07-09 18:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 18:40 [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT Andy Lutomirski
2015-07-09 18:43 ` Kees Cook
2015-07-09 18:51 ` Arjan van de Ven [this message]
2015-07-09 19:00   ` Andy Lutomirski
2015-07-09 19:20   ` Linus Torvalds
2015-07-09 19:42     ` John Stoffel
2015-07-10 13:41       ` Pavel Machek
2015-07-10  8:45     ` Ingo Molnar
2015-07-09 19:27 ` Yuhong Bao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559EC297.3030901@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=ahferroin7@gmail.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).