From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953AbbGJCSs (ORCPT ); Thu, 9 Jul 2015 22:18:48 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:63049 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbbGJCR7 (ORCPT ); Thu, 9 Jul 2015 22:17:59 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-e7-559f2b53fdec Message-id: <559F2B52.4060903@samsung.com> Date: Fri, 10 Jul 2015 11:17:54 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Bartlomiej Zolnierkiewicz , Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar Cc: Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] opp: add dev_pm_opp_get_turbo_mode_setting() helper References: <1436456621-29839-1-git-send-email-b.zolnierkie@samsung.com> <1436456621-29839-2-git-send-email-b.zolnierkie@samsung.com> In-reply-to: <1436456621-29839-2-git-send-email-b.zolnierkie@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t/xy7rB2vNDDa69YrPYOGM9q8X1L89Z Lf4/es1qce33DDaL1y8MLXoXXGWz6H/8mtni6+EVjBZvHm5mtNj0+Bqrxceee6wWl3fNYbP4 3HuE0WLG+X1MFus23mK3uHjK1eLwm3ZWi45ljBZtqz+wWqza9YfRYuNXDwdRj/c3Wtk9/s5u ZfbYOesuu8emVZ1sHneu7WHz2Lyk3uPfMXaPvi2rGD22X5vH7PF5k1wAVxSXTUpqTmZZapG+ XQJXxozmdvaCdZIV/zsnMzUwvhLpYuTkkBAwkWhouc0GYYtJXLi3Hsjm4hASWMoocenNAiaQ hJDAU0aJ3V02IDavgJbEr79v2UFsFgFViXXdO1hAbDYBY4nNy5eADRIViJB4e/kkE0S9oMSP yfdYQIaKCKxnkui9eAtsA7PAS2aJKw/3AlVxcAgL+Ev0LZKH2NzOKPH+6lawbk4BT4n7EztY QGqYBfQk7l/UAgkzC8hLbF7zlnkCo8AsJDtmIVTNQlK1gJF5FaNoamlyQXFSeq6hXnFibnFp Xrpecn7uJkZIXH7Zwbj4mNUhRgEORiUe3gC2+aFCrIllxZW5hxglOJiVRHj5JYBCvCmJlVWp RfnxRaU5qcWHGKU5WJTEeefueh8iJJCeWJKanZpakFoEk2Xi4JRqYIy6//2J6t0D5+eemm9z evEKiV0yXx82esg2+iyeVv/0Qwd7RMm3mkczbvSrOC1ZFHNg9w8H9m+nfHsWrPBrnPcpQvjc TVXmN+HrM8oKP5rZyx5tMNBKyT/5Rpq/9HzFD2upUjGe4tmHlvzd9L1H9X+kZcEORXWRu9a8 88Qd7S907mOfobMv95kSS3FGoqEWc1FxIgBtTmUAxwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.07.2015 00:43, Bartlomiej Zolnierkiewicz wrote: > Add dev_pm_opp_get_turbo_mode_setting() helper for getting turbo > mode setting for a given opp. > > Cc: Tomasz Figa > Cc: Michael Turquette > Cc: Javier Martinez Canillas > Cc: Thomas Abraham > Cc: Viresh Kumar > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/base/power/opp.c | 31 +++++++++++++++++++++++++++++++ > include/linux/pm_opp.h | 7 +++++++ > 2 files changed, 38 insertions(+) > > diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c > index e24502a2..6b34b2a 100644 > --- a/drivers/base/power/opp.c > +++ b/drivers/base/power/opp.c > @@ -287,6 +287,37 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq); > > /** > + * dev_pm_opp_get_turbo_mode_setting() - Gets the turbo setting > + * @opp: opp for which turbo mode setting has to be returned for > + * > + * Return: turbo mode setting corresponding to the opp (true or false) > + * > + * Locking: This function must be called under rcu_read_lock(). opp is a rcu > + * protected pointer. This means that opp which could have been fetched by > + * opp_find_freq_{exact,ceil,floor} functions is valid as long as we are > + * under RCU lock. The pointer returned by the opp_find_freq family must be > + * used in the same section as the usage of this function with the pointer > + * prior to unlocking with rcu_read_unlock() to maintain the integrity of the > + * pointer. > + */ > +bool dev_pm_opp_get_turbo_mode_setting(struct dev_pm_opp *opp) It is just true or false, so maybe dev_pm_opp_is_turbo_mode()? Everything else looks good to me. Best regards, Krzysztof > +{ > + struct dev_pm_opp *tmp_opp; > + bool f = false; > + > + opp_rcu_lockdep_assert(); > + > + tmp_opp = rcu_dereference(opp); > + if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available) > + pr_err("%s: Invalid parameters\n", __func__); > + else > + f = tmp_opp->turbo; > + > + return f; > +} > +EXPORT_SYMBOL_GPL(dev_pm_opp_get_turbo_mode_setting); > + > +/** > * dev_pm_opp_get_max_clock_latency() - Get max clock latency in nanoseconds > * @dev: device for which we do this operation > * > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index bb52fae..7856baf 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -30,6 +30,8 @@ unsigned long dev_pm_opp_get_voltage(struct dev_pm_opp *opp); > > unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp); > > +bool dev_pm_opp_get_turbo_mode_setting(struct dev_pm_opp *opp); > + > int dev_pm_opp_get_opp_count(struct device *dev); > unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev); > > @@ -63,6 +65,11 @@ static inline unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > return 0; > } > > +static inline bool dev_pm_opp_get_turbo_mode_setting(struct dev_pm_opp *opp) > +{ > + return false; > +} > + > static inline int dev_pm_opp_get_opp_count(struct device *dev) > { > return 0; >