From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Phil Edworthy <phil.edworthy@renesas.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0
Date: Fri, 10 Jul 2015 19:36:10 +0300 [thread overview]
Message-ID: <559FF47A.5000001@cogentembedded.com> (raw)
In-Reply-To: <1436270121-25924-1-git-send-email-phil.edworthy@renesas.com>
Hello.
On 07/07/2015 02:55 PM, Phil Edworthy wrote:
> Instead of statically selecting the PHY connection to either the
> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> dts to specifiy gpio pins for the vbus and id signals. Additional
These GPIOs don't have anything to do with the PHY, they're interfacing
Maxim MAX3355 OTG chip for which I have submitted the extcon driver.
> gpio pins are used to control power to an external OTG device and
> an override to turn vbus on/off.
> Note: the R-Car USB PHY only allows this Host/Function switching
> on channel 0.
> This has been tested on a r8a7791 based Koelsch board, which uses
> a MAX3355 device to supply vbus power when needed.
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
I'm inclined to NAK this. You're modifying the wrong driver, I think.
WBR, Sergei
next prev parent reply other threads:[~2015-07-10 16:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 8:05 [PATCH v2] phy: rcar-gen2 usb: Add Host/Function switching for USB0 Phil Edworthy
2015-07-06 7:18 ` Yoshihiro Shimoda
2015-07-07 8:38 ` Phil Edworthy
2015-07-07 11:55 ` [PATCH v3] " Phil Edworthy
2015-07-10 16:36 ` Sergei Shtylyov [this message]
2015-07-13 9:04 ` Phil Edworthy
2015-07-13 10:17 ` Sergei Shtylyov
2015-07-13 15:02 ` Phil Edworthy
2015-07-13 16:37 ` Sergei Shtylyov
2015-07-13 16:55 ` Phil Edworthy
2015-07-13 17:09 ` Sergei Shtylyov
2015-07-13 17:44 ` Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559FF47A.5000001@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox