Re: [PATCH net-next] trace: tcp: Add tracepoint for tcp_sendmsg()

Breno Leitao
2025-02-27T16:26:13Z

On Wed, Feb 26, 2025 at 11:31:49AM -0700, David Ahern wrote:
> On 2/26/25 11:27 AM, Eric Dumazet wrote:
> > In 2022, Menglong Dong added __fix_address
> >
> > Then later , Yafang Shao added noinline_for_tracing .
> >
> > Would one of them be sufficient ?
>
> tcp_sendmsg_locked should not be getting inlined; it is the
> sendmsg_locked handler and directly called by several subsystems.
>
> ie., moving the tracepoint to tcp_sendmsg_locked should solve the inline
> problem. From there, the question is inside the loop or at entry to the
> function. Inside the loop has been very helpful for me.

Inside the loop would work for me as well.