[PATCH] nohz: prevent tilegx network driver interrupts

Chris Metcalf
2015-07-10T17:34:02Z

In nohz_full mode, by default distribute networking shim
interrupts across the housekeeping cores, not all the cores.

Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
---
The alternate approaches to this might be:

1. "#define housekeeping_mask cpu_online_mask" in the non-nohz_full
arm in <linux/tick.h>, then just unconditionally use
"housekeeping_mask".

2. Provide an accessor that returns the cpumask to use for housekeeping
chores and implement it in the obvious ways for both nohz_full
and non-nohz_full.

The latter seems like arguably the most satisfying approach, but
the patch below is, if nothing else, suitable to push for 4.3
without any further API development work.

Frederic (or others), comments?

drivers/net/ethernet/tile/tilegx.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/tile/tilegx.c b/drivers/net/ethernet/tile/tilegx.c
index a3f7610002aa..7687c62e7d75 100644
--- a/drivers/net/ethernet/tile/tilegx.c
+++ b/drivers/net/ethernet/tile/tilegx.c
@@ -40,6 +40,7 @@
#include <linux/tcp.h>
#include <linux/net_tstamp.h>
#include <linux/ptp_clock_kernel.h>
+#include <linux/tick.h>

#include <asm/checksum.h>
#include <asm/homecache.h>
@@ -2272,8 +2273,13 @@ static int __init tile_net_init_module(void)
for (i = 0; gxio_mpipe_link_enumerate_mac(i, name, mac) >= 0; i++)
tile_net_dev_init(name, mac);

- if (!network_cpus_init())
+ if (!network_cpus_init()) {
+#ifdef CONFIG_NO_HZ_FULL
+ network_cpus_map = *housekeeping_mask;
+#else
network_cpus_map = *cpu_online_mask;
+#endif
+ }

return 0;
}
--
2.1.2