From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbbGKRcz (ORCPT ); Sat, 11 Jul 2015 13:32:55 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:48842 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbbGKRct (ORCPT ); Sat, 11 Jul 2015 13:32:49 -0400 Message-ID: <55A1533A.2080507@kernel.org> Date: Sat, 11 Jul 2015 18:32:42 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Heiko Stuebner CC: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-iio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data References: <8215730.uluDfnE1h7@diego> In-Reply-To: <8215730.uluDfnE1h7@diego> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/15 15:17, Heiko Stuebner wrote: > The module-data is currently missing. This includes the license-information > which makes the driver taint the kernel and miss symbols when compiled as > module. > > Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc") > Signed-off-by: Heiko Stuebner Sorry Heiko, Not entirely sure why I haven't picked this up before. Anyhow, now applied to the fixes-for-4.2 branch of iio.git and marked for stable. I need to catch up with a bit of a backlog, but should get a pull request out to Greg sometime early next week. Jonathan > --- > drivers/iio/adc/rockchip_saradc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index 8d4e019..9c311c1 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c > @@ -349,3 +349,7 @@ static struct platform_driver rockchip_saradc_driver = { > }; > > module_platform_driver(rockchip_saradc_driver); > + > +MODULE_AUTHOR("Heiko Stuebner "); > +MODULE_DESCRIPTION("Rockchip SARADC driver"); > +MODULE_LICENSE("GPL v2"); >