[PATCH] Drop owner assignment from i2c_driver (and platform left-overs)

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] Drop owner assignment from i2c_driver (and platform left-overs)
@ 2015-07-10  6:34 Krzysztof Kozlowski
  2015-07-10  6:34 ` [PATCH 1/3] staging: iio: Drop owner assignment from i2c_driver Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10  6:34 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, Jarod Wilson,
	Mauro Carvalho Chehab, Antti Palosaari, linux-iio, devel,
	linux-kernel, linux-media
  Cc: Krzysztof Kozlowski

Hi,


The i2c drivers also do not have to set 'owner' field because
i2c_register_driver() will do it instead.

'owner' is removed from i2c drivers, which I was able to compile
with allyesconfig (arm, arm64, i386, x86_64, ppc64).
Only compile-tested.

The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html


Best regards,
Krzysztof


Krzysztof Kozlowski (3):
  staging: iio: Drop owner assignment from i2c_driver
  staging: media: Drop owner assignment from i2c_driver
  staging: Drop owner assignment from i2c_driver

 drivers/staging/iio/addac/adt7316-i2c.c       | 1 -
 drivers/staging/iio/light/isl29018.c          | 1 -
 drivers/staging/iio/light/isl29028.c          | 1 -
 drivers/staging/media/lirc/lirc_zilog.c       | 1 -
 drivers/staging/media/mn88472/mn88472.c       | 1 -
 drivers/staging/media/mn88473/mn88473.c       | 1 -
 drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 1 -
 7 files changed, 7 deletions(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] staging: iio: Drop owner assignment from i2c_driver
  2015-07-10  6:34 [PATCH] Drop owner assignment from i2c_driver (and platform left-overs) Krzysztof Kozlowski
@ 2015-07-10  6:34 ` Krzysztof Kozlowski
  2015-07-11 17:47   ` Jonathan Cameron
  2015-07-10  6:34 ` [PATCH 2/3] staging: media: " Krzysztof Kozlowski
  2015-07-10  6:34 ` [PATCH 3/3] staging: " Krzysztof Kozlowski
  2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10  6:34 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, Jarod Wilson,
	Mauro Carvalho Chehab, Antti Palosaari, linux-iio, devel,
	linux-kernel, linux-media
  Cc: Krzysztof Kozlowski

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
 drivers/staging/iio/addac/adt7316-i2c.c | 1 -
 drivers/staging/iio/light/isl29018.c    | 1 -
 drivers/staging/iio/light/isl29028.c    | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio/addac/adt7316-i2c.c
index 75ddd4f801a3..78fe0b557280 100644
--- a/drivers/staging/iio/addac/adt7316-i2c.c
+++ b/drivers/staging/iio/addac/adt7316-i2c.c
@@ -124,7 +124,6 @@ static struct i2c_driver adt7316_driver = {
 	.driver = {
 		.name = "adt7316",
 		.pm = ADT7316_PM_OPS,
-		.owner  = THIS_MODULE,
 	},
 	.probe = adt7316_i2c_probe,
 	.id_table = adt7316_i2c_id,
diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index e646c5d24004..019ba5245c23 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -838,7 +838,6 @@ static struct i2c_driver isl29018_driver = {
 			.name = "isl29018",
 			.acpi_match_table = ACPI_PTR(isl29018_acpi_match),
 			.pm = ISL29018_PM_OPS,
-			.owner = THIS_MODULE,
 			.of_match_table = isl29018_of_match,
 		    },
 	.probe	 = isl29018_probe,
diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index e5b2fdc2334b..cd6f2727aa58 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -547,7 +547,6 @@ static struct i2c_driver isl29028_driver = {
 	.class	= I2C_CLASS_HWMON,
 	.driver  = {
 		.name = "isl29028",
-		.owner = THIS_MODULE,
 		.of_match_table = isl29028_of_match,
 	},
 	.probe	 = isl29028_probe,
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] staging: iio: Drop owner assignment from i2c_driver
  2015-07-10  6:34 ` [PATCH 1/3] staging: iio: Drop owner assignment from i2c_driver Krzysztof Kozlowski
@ 2015-07-11 17:47   ` Jonathan Cameron
  0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2015-07-11 17:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Lars-Peter Clausen, Michael Hennerich,
	Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, Jarod Wilson,
	Mauro Carvalho Chehab, Antti Palosaari, linux-iio, devel,
	linux-kernel, linux-media

On 10/07/15 07:34, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Applied to the togreg branch of iio.git

Thanks,

Jonathan
> 
> ---
> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/staging/iio/addac/adt7316-i2c.c | 1 -
>  drivers/staging/iio/light/isl29018.c    | 1 -
>  drivers/staging/iio/light/isl29028.c    | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio/addac/adt7316-i2c.c
> index 75ddd4f801a3..78fe0b557280 100644
> --- a/drivers/staging/iio/addac/adt7316-i2c.c
> +++ b/drivers/staging/iio/addac/adt7316-i2c.c
> @@ -124,7 +124,6 @@ static struct i2c_driver adt7316_driver = {
>  	.driver = {
>  		.name = "adt7316",
>  		.pm = ADT7316_PM_OPS,
> -		.owner  = THIS_MODULE,
>  	},
>  	.probe = adt7316_i2c_probe,
>  	.id_table = adt7316_i2c_id,
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index e646c5d24004..019ba5245c23 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -838,7 +838,6 @@ static struct i2c_driver isl29018_driver = {
>  			.name = "isl29018",
>  			.acpi_match_table = ACPI_PTR(isl29018_acpi_match),
>  			.pm = ISL29018_PM_OPS,
> -			.owner = THIS_MODULE,
>  			.of_match_table = isl29018_of_match,
>  		    },
>  	.probe	 = isl29018_probe,
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index e5b2fdc2334b..cd6f2727aa58 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -547,7 +547,6 @@ static struct i2c_driver isl29028_driver = {
>  	.class	= I2C_CLASS_HWMON,
>  	.driver  = {
>  		.name = "isl29028",
> -		.owner = THIS_MODULE,
>  		.of_match_table = isl29028_of_match,
>  	},
>  	.probe	 = isl29028_probe,
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/3] staging: media: Drop owner assignment from i2c_driver
  2015-07-10  6:34 [PATCH] Drop owner assignment from i2c_driver (and platform left-overs) Krzysztof Kozlowski
  2015-07-10  6:34 ` [PATCH 1/3] staging: iio: Drop owner assignment from i2c_driver Krzysztof Kozlowski
@ 2015-07-10  6:34 ` Krzysztof Kozlowski
  2015-07-10  6:34 ` [PATCH 3/3] staging: " Krzysztof Kozlowski
  2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10  6:34 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, Jarod Wilson,
	Mauro Carvalho Chehab, Antti Palosaari, linux-iio, devel,
	linux-kernel, linux-media
  Cc: Krzysztof Kozlowski

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
 drivers/staging/media/lirc/lirc_zilog.c | 1 -
 drivers/staging/media/mn88472/mn88472.c | 1 -
 drivers/staging/media/mn88473/mn88473.c | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
index 261e27d6b054..d032745081ee 100644
--- a/drivers/staging/media/lirc/lirc_zilog.c
+++ b/drivers/staging/media/lirc/lirc_zilog.c
@@ -1367,7 +1367,6 @@ static const struct i2c_device_id ir_transceiver_id[] = {
 
 static struct i2c_driver driver = {
 	.driver = {
-		.owner	= THIS_MODULE,
 		.name	= "Zilog/Hauppauge i2c IR",
 	},
 	.probe		= ir_probe,
diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
index a8d45f44765c..cf2e96bcf395 100644
--- a/drivers/staging/media/mn88472/mn88472.c
+++ b/drivers/staging/media/mn88472/mn88472.c
@@ -561,7 +561,6 @@ MODULE_DEVICE_TABLE(i2c, mn88472_id_table);
 
 static struct i2c_driver mn88472_driver = {
 	.driver = {
-		.owner	= THIS_MODULE,
 		.name	= "mn88472",
 	},
 	.probe		= mn88472_probe,
diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c
index f9146a146d07..a222e99935d2 100644
--- a/drivers/staging/media/mn88473/mn88473.c
+++ b/drivers/staging/media/mn88473/mn88473.c
@@ -507,7 +507,6 @@ MODULE_DEVICE_TABLE(i2c, mn88473_id_table);
 
 static struct i2c_driver mn88473_driver = {
 	.driver = {
-		.owner	= THIS_MODULE,
 		.name	= "mn88473",
 	},
 	.probe		= mn88473_probe,
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] staging: Drop owner assignment from i2c_driver
  2015-07-10  6:34 [PATCH] Drop owner assignment from i2c_driver (and platform left-overs) Krzysztof Kozlowski
  2015-07-10  6:34 ` [PATCH 1/3] staging: iio: Drop owner assignment from i2c_driver Krzysztof Kozlowski
  2015-07-10  6:34 ` [PATCH 2/3] staging: media: " Krzysztof Kozlowski
@ 2015-07-10  6:34 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10  6:34 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, Jarod Wilson,
	Mauro Carvalho Chehab, Antti Palosaari, linux-iio, devel,
	linux-kernel, linux-media
  Cc: Krzysztof Kozlowski

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
 drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
index 0f524bb7b41d..1f9ba8beb061 100644
--- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
+++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
@@ -1126,7 +1126,6 @@ MODULE_DEVICE_TABLE(i2c, synaptics_rmi4_id_table);
 static struct i2c_driver synaptics_rmi4_driver = {
 	.driver = {
 		.name	=	DRIVER_NAME,
-		.owner	=	THIS_MODULE,
 		.pm	=	&synaptics_rmi4_dev_pm_ops,
 	},
 	.probe		=	synaptics_rmi4_probe,
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-07-11 17:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-10  6:34 [PATCH] Drop owner assignment from i2c_driver (and platform left-overs) Krzysztof Kozlowski
2015-07-10  6:34 ` [PATCH 1/3] staging: iio: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-07-11 17:47   ` Jonathan Cameron
2015-07-10  6:34 ` [PATCH 2/3] staging: media: " Krzysztof Kozlowski
2015-07-10  6:34 ` [PATCH 3/3] staging: " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox