Re: [PATCH v3 09/10] KVM: MMU: fix MTRR update

Paolo Bonzini
2015-05-14T08:43:56Z

On 14/05/2015 02:16, Wanpeng Li wrote:
> >SPTEs are kept around and cached. The "role" field is used as the hash
> >key; if the role doesn't change, SPTEs are reused, so you have to zap
> >the SPTEs explicitly.
>
> Btw, why the patch changelog mentioned that the root shadow page will be
> reused, I think it will be zapped in mmu_free_roots.

Who has set sp->role.invalid on it? If no one has, it's not zapped and
it will be found again in the hash table.

Paolo