From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbbGMIUb (ORCPT ); Mon, 13 Jul 2015 04:20:31 -0400 Received: from lists.s-osg.org ([54.187.51.154]:52652 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbbGMIU3 (ORCPT ); Mon, 13 Jul 2015 04:20:29 -0400 Subject: Re: [PATCH 3/3] mfd: max77686: Split out regulator part from the DT binding To: Krzysztof Kozlowski , Lee Jones References: <1436773348-15316-1-git-send-email-javier@osg.samsung.com> <1436773348-15316-4-git-send-email-javier@osg.samsung.com> <55A370CE.6080904@samsung.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <55A374C8.8020103@osg.samsung.com> Date: Mon, 13 Jul 2015 10:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <55A370CE.6080904@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 07/13/2015 10:03 AM, Krzysztof Kozlowski wrote: > On 13.07.2015 16:42, Javier Martinez Canillas wrote: >> The Maxim MAX77686 PMIC is a multi-function device with regulators, >> clocks and a RTC. The DT bindings for the clocks are in a separate >> file but the bindings for the regulators are inside the mfd part. >> >> To make it consistent with the clocks portion of the binding and >> because is more natural to look for regulator bindings under the >> bindings/regulator sub-directory, split the regulator portion of >> the DT binding and add it as a separate file. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- >> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ >> 2 files changed, 74 insertions(+), 55 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt > > Actually I would prefer the opposite - merging everything into one file > (clocks, regulators -> mfd) because: > > 1. Separate files introduce some duplication (like introduction and > common part of example node). > > 2. It is easier to track the changes and update them. For example when > adding a new chipset to the driver one may forgot about updating other > files. When moving files one may forgot to update hard-coded path in > some other file. > > 3. When comparing existing DTS with documentation or when creating new > DTS for the device it is just faster to fetch everything (knowledge, > example node) from one file. > Yes, I also wondered about going the opposite way but then thought that is more natural to look for clock bindings under bindings/clock and for regulators drivers under bindings/regulator... > However I understand that such opinion may be not suited for the idea of > MFD... > ...but I don't have a strong opinion and can do the other way if folks are more fond with that single file approach. What I think is that it should be consistent, either everything is in mfd for all PMICs or everything is split. The max77686 for example has a somehow arbitrary split since the clocks are in another file but the regulators are in the same mfd binding doc. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America