public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Devera <martin.devera@cdi.cz>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Add NXP LPC32XX SPI driver
Date: Mon, 13 Jul 2015 14:26:14 +0200	[thread overview]
Message-ID: <55A3AE66.1070705@cdi.cz> (raw)
In-Reply-To: <1436789948.2679.23.camel@tiscali.nl>

Paul Bolle wrote:
> (This hit my box with lkml mesages without lkml in the To: header. What
> happened here?)

Ahh, have to check my sending script ..

> On zo, 2015-07-12 at 11:20 +0200, Martin Devera wrote:
>> --- /dev/null
>> +++ b/drivers/spi/spi-lpc32xx.c
> 
>> +#define DRIVER_NAME	"spi-lpc32xx"
> 
>> +MODULE_ALIAS("platform:" DRIVER_NAME);
> 
> This alias seems only useful if there's a corresponding struct
> platform_device. Ie, a struct platform_device with a .name of "spi
> -lpc32xx", which will fire off a "MODALIAS=platform:spi-lpc32xx" uevent
> when it's created.

My fault, thanks for spotting. It is leftover from driver I used
as template...
In any case, I has other comments from Joachim Eastwood thus I plan
to do more cleanup and resubmit the driver later..

thanks,
Martin

      reply	other threads:[~2015-07-13 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-12  9:20 [PATCH 1/2] Add NXP LPC32XX SPI driver Martin Devera
2015-07-13 12:19 ` Paul Bolle
2015-07-13 12:26   ` Martin Devera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A3AE66.1070705@cdi.cz \
    --to=martin.devera@cdi.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox