From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Linus Walleij <linus.walleij@linaro.org>,
linux-leds@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Allow compile test of LEDS_AAT1290 and LEDS_KTD2692 if !GPIOLIB
Date: Mon, 13 Jul 2015 14:39:53 +0200 [thread overview]
Message-ID: <55A3B199.7010308@samsung.com> (raw)
In-Reply-To: <1436190154-11517-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
Thanks for the patch.
On 07/06/2015 03:42 PM, Geert Uytterhoeven wrote:
> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> If COMPILE_TEST is enabled, relax the dependency on GPIOLIB for the
> recently introduced symbols LEDS_AAT1290 and LEDS_KTD2692.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/leds/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 94eced66d877182b..cf0248b8dbb9c023 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -43,7 +43,7 @@ config LEDS_AAT1290
> tristate "LED support for the AAT1290"
> depends on LEDS_CLASS_FLASH
> depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> - depends on GPIOLIB
> + depends on GPIOLIB || COMPILE_TEST
> depends on OF
> depends on PINCTRL
> help
> @@ -543,7 +543,8 @@ config LEDS_MENF21BMC
>
> config LEDS_KTD2692
> tristate "LED support for KTD2692 flash LED controller"
> - depends on LEDS_CLASS_FLASH && GPIOLIB && OF
> + depends on LEDS_CLASS_FLASH && OF
> + depends on GPIOLIB || COMPILE_TEST
> help
> This option enables support for KTD2692 LED flash connected
> through ExpressWire interface.
>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best Regards,
Jacek Anaszewski
prev parent reply other threads:[~2015-07-13 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 13:42 [PATCH] leds: Allow compile test of LEDS_AAT1290 and LEDS_KTD2692 if !GPIOLIB Geert Uytterhoeven
2015-07-06 15:13 ` Jacek Anaszewski
2015-07-13 12:39 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3B199.7010308@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=cooloney@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox