From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753895AbbGNLEi (ORCPT ); Tue, 14 Jul 2015 07:04:38 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:34025 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753767AbbGNLEg (ORCPT ); Tue, 14 Jul 2015 07:04:36 -0400 Subject: Re: [PATCH v2 42/48] usb: gadget: epautoconf: use 'ep_match' gadget callback To: Robert Baldyga , gregkh@linuxfoundation.org, balbi@ti.com References: <1436866776-5004-1-git-send-email-r.baldyga@samsung.com> <1436866776-5004-43-git-send-email-r.baldyga@samsung.com> Cc: Peter.Chen@freescale.com, johnyoun@synopsys.com, dahlmann.thomas@arcor.de, nicolas.ferre@atmel.com, cernekee@gmail.com, leoli@freescale.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, michal.simek@xilinx.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-geode@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, andrzej.p@samsung.com, m.szyprowski@samsung.com From: Sergei Shtylyov Message-ID: <55A4ECC0.4030205@cogentembedded.com> Date: Tue, 14 Jul 2015 14:04:32 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1436866776-5004-43-git-send-email-r.baldyga@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: > If gadget has set 'ep_match' callback we prefer to call it first to allow > UDC driver to find the best matching endpoint basing on chip-specific "best > usage" knowledge. > Signed-off-by: Robert Baldyga > --- > drivers/usb/gadget/epautoconf.c | 6 ++++++ > 1 file changed, 6 insertions(+) > diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c > index ee0d4e6..92a1a4c 100644 > --- a/drivers/usb/gadget/epautoconf.c > +++ b/drivers/usb/gadget/epautoconf.c > @@ -165,6 +165,12 @@ struct usb_ep *usb_ep_autoconfig_ss( > > type = desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK; > > + if (gadget->ops->match_ep) { > + ep = gadget->ops->match_ep(gadget, desc, ep_comp); > + if (ep) > + goto found_ep; > + } > + I think this patch should be merged with the previous one. [...] WBR, Sergei