From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-kernel@vger.kernel.org>, <snitzer@redhat.com>
Subject: Re: [PATCH 0/2] Configurable max discard size
Date: Tue, 14 Jul 2015 12:36:18 -0600 [thread overview]
Message-ID: <55A556A2.8040605@fb.com> (raw)
In-Reply-To: <20150714175317.GA30609@lst.de>
On 07/14/2015 11:53 AM, Christoph Hellwig wrote:
> On Tue, Jul 14, 2015 at 10:04:12AM -0600, Jens Axboe wrote:
>> Based on experimentation with two different vendors, 64MB would be a good
>> default. Question is how best to set that. At least with the current patch,
>> untouched, 'discard_max_bytes' will still show the hw max value. If I
>> default it to 64MB, we'd lose that information until people started bumping
>> it up in size. Maybe that's not such a big deal, however.
>
> Just expose the max value as another read-only sysfs value?
Sure, just didn't want to clutter it with Yet Another sysfs file. But we
could add 'discard_max_hw_bytes', that would be the obvious choice.
--
Jens Axboe
prev parent reply other threads:[~2015-07-14 18:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 15:02 [PATCH 0/2] Configurable max discard size Jens Axboe
2015-07-14 15:02 ` [PATCH 1/2] block: have drivers use blk_queue_max_discard_sectors() Jens Axboe
2015-07-14 15:02 ` [PATCH 2/2] block: make /sys/block/<dev>/queue/discard_max_bytes writeable Jens Axboe
2015-07-14 15:23 ` Mike Snitzer
2015-07-14 15:29 ` Jens Axboe
2015-07-14 16:01 ` [PATCH 0/2] Configurable max discard size Christoph Hellwig
2015-07-14 16:04 ` Jens Axboe
2015-07-14 17:53 ` Christoph Hellwig
2015-07-14 18:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A556A2.8040605@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox