* [PATCH] phy: ulpi_phy: Add const qualifier to ops @ 2015-06-05 0:27 Axel Lin 2015-07-15 7:10 ` Axel Lin 0 siblings, 1 reply; 3+ messages in thread From: Axel Lin @ 2015-06-05 0:27 UTC (permalink / raw) To: Kishon Vijay Abraham I, Felipe Balbi Cc: David Cohen, linux-kernel, linux-usb@vger.kernel.org The ops is never changed in ulpi_phy_create(), so make it const. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/phy/ulpi_phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h index ac49fb6..f2ebe49 100644 --- a/drivers/phy/ulpi_phy.h +++ b/drivers/phy/ulpi_phy.h @@ -5,7 +5,7 @@ * and it's controller, which is always the parent. */ static inline struct phy -*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) +*ulpi_phy_create(struct ulpi *ulpi, const struct phy_ops *ops) { struct phy *phy; int ret; -- 2.1.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops 2015-06-05 0:27 [PATCH] phy: ulpi_phy: Add const qualifier to ops Axel Lin @ 2015-07-15 7:10 ` Axel Lin 2015-07-15 8:04 ` Kishon Vijay Abraham I 0 siblings, 1 reply; 3+ messages in thread From: Axel Lin @ 2015-07-15 7:10 UTC (permalink / raw) To: Kishon Vijay Abraham I, Felipe Balbi Cc: David Cohen, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org 2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>: > The ops is never changed in ulpi_phy_create(), so make it const. Hi Kishon, Would you pick up this patch? Without this patch, passing a const struct phy_ops* to ulip_phy_create will have compiler warning. It should be fine to pass a const struct phy_ops* to ulip_phy_create and since the drivers usually never change phy_ops after initialized, it can be const. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops 2015-07-15 7:10 ` Axel Lin @ 2015-07-15 8:04 ` Kishon Vijay Abraham I 0 siblings, 0 replies; 3+ messages in thread From: Kishon Vijay Abraham I @ 2015-07-15 8:04 UTC (permalink / raw) To: Axel Lin, Felipe Balbi Cc: David Cohen, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Hi Axel, On Wednesday 15 July 2015 12:40 PM, Axel Lin wrote: > 2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>: >> The ops is never changed in ulpi_phy_create(), so make it const. > > Hi Kishon, > > Would you pick up this patch? yes.. I'll take once I start queuing the patches. Thanks Kishon ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-15 8:05 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-06-05 0:27 [PATCH] phy: ulpi_phy: Add const qualifier to ops Axel Lin 2015-07-15 7:10 ` Axel Lin 2015-07-15 8:04 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox