From: Peter Hung <hpeter@gmail.com>
To: Paul Bolle <pebolle@tiscali.nl>, johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, tom_tsai@fintek.com.tw,
peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver
Date: Wed, 15 Jul 2015 16:55:19 +0800 [thread overview]
Message-ID: <55A61FF7.5030804@gmail.com> (raw)
In-Reply-To: <1436949405.2679.67.camel@tiscali.nl>
Hi Paul & Johan
Paul Bolle 於 2015/7/15 下午 04:36 寫道:
> Just a few nits, I'm afraid.
>> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset)
>> +{
>> + [...]
>> +}
>
> static?
Thanks Paul for point this out.
And sorry for Johan. It's seems to make a new patch V5. I'll merge
some minor fix with newer patch.
--
With Best Regards,
Peter Hung
next prev parent reply other threads:[~2015-07-15 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 3:13 [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver Peter Hung
2015-07-15 8:36 ` Paul Bolle
2015-07-15 8:55 ` Peter Hung [this message]
2015-07-15 9:53 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A61FF7.5030804@gmail.com \
--to=hpeter@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox