From: Xander Huff <xander.huff@ni.com>
To: Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>
Cc: jic23@kernel.org, bigeasy@linutronix.de, lars@metafoo.de,
nathan.sullivan@ni.com, linux-rt-users@vger.kernel.org,
linux-iio@vger.kernel.org, jaeden.amero@ni.com, joshc@ni.com,
michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
joe.hershberger@ni.com, linux-arm-kernel@lists.infradead.org,
pmeerw@pmeerw.net, knaack.h@gmx.de, soren.brinkmann@xilinx.com
Subject: Re: [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context
Date: Wed, 15 Jul 2015 10:57:44 -0500 [thread overview]
Message-ID: <55A682F8.3090001@ni.com> (raw)
In-Reply-To: <CAKfKVtGTO81wLWk50M303t2WjcBEMEt_LUnsJ3_WmvR_3izUjg@mail.gmail.com>
On 7/9/2015 12:03 AM, Shubhrajyoti Datta wrote:
> @@ -330,8 +310,18 @@ static irqreturn_t xadc_zynq_interrupt_handler(int irq,
> void *devid)
> xadc_zynq_update_intmsk(xadc, 0, 0);
> ret = IRQ_WAKE_THREAD;
> }
> +
> + alarm = xadc->zynq_alarm;
> + xadc->zynq_alarm = 0;
> +
> spin_unlock(&xadc->lock);
>
> + xadc_handle_events(indio_dev, xadc_zynq_transform_alarm(alarm));
> +
> + /* unmask the required interrupts in timer. */
> + schedule_delayed_work(&xadc->zynq_unmask_work,
> + msecs_to_jiffies(XADC_ZYNQ_UNMASK_TIMEOUT));
> +
>
> Now that we are in the threaded context do we need the work queue stuff.
Seems reasonable to try to remove it. I'll do some testing and send out a v3 if
it works, thanks.
--
Xander Huff
Staff Software Engineer
National Instruments
next prev parent reply other threads:[~2015-07-15 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5574633F.7090004@kernel.org>
2015-07-08 21:38 ` [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context Xander Huff
2015-07-14 14:28 ` Sebastian Andrzej Siewior
2015-07-15 15:59 ` Xander Huff
[not found] ` <CAKfKVtGTO81wLWk50M303t2WjcBEMEt_LUnsJ3_WmvR_3izUjg@mail.gmail.com>
2015-07-15 15:57 ` Xander Huff [this message]
2015-07-20 23:14 ` [PATCH v3] " Xander Huff
2015-07-24 12:38 ` Lars-Peter Clausen
2015-08-03 20:18 ` Xander Huff
2015-08-04 8:01 ` Lars-Peter Clausen
2015-08-11 23:00 ` [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context Xander Huff
2015-08-12 15:17 ` Lars-Peter Clausen
2015-08-12 16:33 ` Sebastian Andrzej Siewior
2015-08-15 19:55 ` Jonathan Cameron
2015-08-04 5:34 ` [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context Shubhrajyoti Datta
2015-08-04 8:05 ` Lars-Peter Clausen
2015-08-07 3:55 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A682F8.3090001@ni.com \
--to=xander.huff@ni.com \
--cc=bigeasy@linutronix.de \
--cc=jaeden.amero@ni.com \
--cc=jic23@kernel.org \
--cc=joe.hershberger@ni.com \
--cc=joshc@ni.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nathan.sullivan@ni.com \
--cc=pmeerw@pmeerw.net \
--cc=shubhrajyoti.datta@gmail.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox