From: Xander Huff <xander.huff@ni.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, michal.simek@xilinx.com,
soren.brinkmann@xilinx.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rt-users@vger.kernel.org, joe.hershberger@ni.com,
joshc@ni.com, nathan.sullivan@ni.com, jaeden.amero@ni.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context
Date: Wed, 15 Jul 2015 10:59:25 -0500 [thread overview]
Message-ID: <55A6835D.1000401@ni.com> (raw)
In-Reply-To: <20150714142846.GB21820@linutronix.de>
On 7/14/2015 9:28 AM, Sebastian Andrzej Siewior wrote:
> * Xander Huff | 2015-07-08 16:38:22 [-0500]:
>
>> drivers/iio/adc/xilinx-xadc-core.c | 35 ++++++++++++-----------------------
>> 1 file changed, 12 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
>> index ce93bd8..b309ad3 100644
>> --- a/drivers/iio/adc/xilinx-xadc-core.c
>> +++ b/drivers/iio/adc/xilinx-xadc-core.c
>> @@ -1225,7 +1214,7 @@ static int xadc_probe(struct platform_device *pdev)
>> if (ret)
>> goto err_free_samplerate_trigger;
>>
>> - ret = request_threaded_irq(irq, xadc->ops->interrupt_handler,
>> + ret = request_threaded_irq(irq, 0,
>
> NULL not 0
> Other than that, it looks good. Thanks.
> If you managed to get this merged upstream then feel free to ping me and
> I pick this into -RT.
>
>> xadc->ops->threaded_interrupt_handler,
>> 0, dev_name(&pdev->dev), indio_dev);
>> if (ret)
>
> Sebastian
>
Haven't got this merged in yet. I'm addressing another concern from Shubhrajyoti
Datta and will include this change in my v3 I'll send out sometime next week,
thanks!
--
Xander Huff
Staff Software Engineer
National Instruments
next prev parent reply other threads:[~2015-07-15 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5574633F.7090004@kernel.org>
2015-07-08 21:38 ` [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context Xander Huff
2015-07-14 14:28 ` Sebastian Andrzej Siewior
2015-07-15 15:59 ` Xander Huff [this message]
[not found] ` <CAKfKVtGTO81wLWk50M303t2WjcBEMEt_LUnsJ3_WmvR_3izUjg@mail.gmail.com>
2015-07-15 15:57 ` Xander Huff
2015-07-20 23:14 ` [PATCH v3] " Xander Huff
2015-07-24 12:38 ` Lars-Peter Clausen
2015-08-03 20:18 ` Xander Huff
2015-08-04 8:01 ` Lars-Peter Clausen
2015-08-11 23:00 ` [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context Xander Huff
2015-08-12 15:17 ` Lars-Peter Clausen
2015-08-12 16:33 ` Sebastian Andrzej Siewior
2015-08-15 19:55 ` Jonathan Cameron
2015-08-04 5:34 ` [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context Shubhrajyoti Datta
2015-08-04 8:05 ` Lars-Peter Clausen
2015-08-07 3:55 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A6835D.1000401@ni.com \
--to=xander.huff@ni.com \
--cc=bigeasy@linutronix.de \
--cc=jaeden.amero@ni.com \
--cc=jic23@kernel.org \
--cc=joe.hershberger@ni.com \
--cc=joshc@ni.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nathan.sullivan@ni.com \
--cc=pmeerw@pmeerw.net \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox