From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbbGPApX (ORCPT ); Wed, 15 Jul 2015 20:45:23 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:26120 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbbGPApV (ORCPT ); Wed, 15 Jul 2015 20:45:21 -0400 X-AuditID: cbfec7f5-f794b6d000001495-ea-55a6fe9e1c08 Message-id: <55A6FEA0.8090202@samsung.com> Date: Thu, 16 Jul 2015 09:45:20 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: linux-samsung-soc@vger.kernel.org, Kevin Hilman , Arnd Bergmann , linux-kernel@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] ARM: multi_v7_defconfig: Enable max77802 regulator References: <1436977965-7078-1-git-send-email-javier@osg.samsung.com> <1436977965-7078-2-git-send-email-javier@osg.samsung.com> In-reply-to: <1436977965-7078-2-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xa7rz/i0LNdh+n9/i76Rj7BZv3q5h snj9wtCi//FrZouvh1cwWmx6fI3V4vKuOWwWM87vY7I4df0zmwOnx+9fkxg9Nq3qZPO4c20P m8fmJfUeV040sXps6b/L7tG3ZRWjx+dNcgEcUVw2Kak5mWWpRfp2CVwZyw4vZC6Yw11x5P1G 1gbGbZxdjJwcEgImEue/XmWHsMUkLtxbz9bFyMUhJLCUUeLjtt2MEM5TRolV/T8ZQap4BbQk 1p64xQpiswioSpxecwYsziZgLLF5+RI2EFtUIELi7eWTTBD1ghI/Jt9jAbFFBMIk5rYfZAUZ yixwgVFiy8ZOsNXCAt4Sx3qeQW1rZJT4t28t2AZOATeJr4uWARVxAHXoSdy/qAUSZhaQl9i8 5i3zBEaBWUh2zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkKj4uoNx6TGr Q4wCHIxKPLwcv5eFCrEmlhVX5h5ilOBgVhLh9XoJFOJNSaysSi3Kjy8qzUktPsQozcGiJM47 c9f7ECGB9MSS1OzU1ILUIpgsEwenVAPjoZU5kb7CYYGn5H/e7DLgNbE7cdx9w9Xr878HZLNk JGxa+lrtSyJn3RzP8yf/yv8TrdDbrWnzwbJgue2SH3zP7OYfXFi5vl9o53wha6UCxXiOidZH d224e4vf+KGihtXs0+seyadWVuYZMKxXv3dasVMydY3vrJ0ckbZOQacl626n7Vuc2bNDiaU4 I9FQi7moOBEA80xep4YCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.07.2015 01:32, Javier Martinez Canillas wrote: > The Maxim max77802 Power Management IC has besides other devices, a set of > regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 > regulator, rtc and clock drivers") was supposed to enable the config option > for the regulator driver as a module but the final version that landed did > not include this. So this patch enables the needed Kconfig option. > > Signed-off-by: Javier Martinez Canillas Please describe why do you want to enable it (IOW who will benefit from enabling it?). This symbol was removed by Kukjin from your commit: [kgene@kernel.org: removing useless REGULATOR_MAX77802 config] so justification would be welcomed. Beside the commit description I agree with the patch. Best regards, Krzysztof > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 4b93761d58d2..b07493997993 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -402,6 +402,7 @@ CONFIG_REGULATOR_MAX14577=m > CONFIG_REGULATOR_MAX8907=y > CONFIG_REGULATOR_MAX8973=y > CONFIG_REGULATOR_MAX77686=y > +CONFIG_REGULATOR_MAX77802=m > CONFIG_REGULATOR_MAX77693=m > CONFIG_REGULATOR_PALMAS=y > CONFIG_REGULATOR_S2MPS11=y >