From: Keerthy <a0393675@ti.com>
To: Paul Walmsley <paul@pwsan.com>, Keerthy <j-keerthy@ti.com>
Cc: <tony@atomide.com>, <t-kristo@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bcousson@baylibre.com>, <galak@codeaurora.org>,
<pawel.moll@arm.com>
Subject: Re: [PATCH v2 2/6] ARM: AM43xx: Add the PRM IRQ register offsets
Date: Thu, 16 Jul 2015 10:46:43 +0530 [thread overview]
Message-ID: <55A73E3B.1010705@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1507160237280.32764@utopia.booyaka.com>
On Thursday 16 July 2015 08:08 AM, Paul Walmsley wrote:
> On Thu, 16 Jul 2015, Paul Walmsley wrote:
>
>> On Wed, 8 Jul 2015, Keerthy wrote:
>>
>>> Add the PRM IRQ register offsets.
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>
>> Please add more detail to your commit messages so they conform to
>> Documentation/SubmittingPatches:
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n109
>>
>> For example, this commit message should read something like:
>>
>> ---
>>
>> ARM: AM43xx: Add the PRM IRQ register offsets
>>
>> Add the PRM IRQ register offsets. This is needed to support PRM I/O
>> wakeup on AM43xx.
>>
>> --
>>
>> Basically, your patches need to provide context as to _why_ the change is
>> needed.
>>
>> I've fixed the message for this patch, and queued it for v4.3, but
>> please take care with this issue in the future.
>
> Also I've moved the AM43XX_PRM_IO_PMCTRL_OFFSET macro out of the AM43XX CM
> section, since it doesn't belong there.
Thanks Paul!
>
>
> - Paul
>
next prev parent reply other threads:[~2015-07-16 5:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 5:42 [PATCH v2 0/6] ARM: AM437x: Add IO wake up support Keerthy
2015-07-08 5:42 ` [PATCH v2 1/6] ARM: OMAP4: PRM: Remove hardcoding of PRM_IO_PMCTRL_OFFSET register Keerthy
2015-07-16 1:54 ` Paul Walmsley
2015-07-16 5:16 ` Keerthy
2015-07-08 5:42 ` [PATCH v2 2/6] ARM: AM43xx: Add the PRM IRQ register offsets Keerthy
2015-07-16 2:33 ` Paul Walmsley
2015-07-16 2:38 ` Paul Walmsley
2015-07-16 5:16 ` Keerthy [this message]
2015-07-08 5:42 ` [PATCH v2 3/6] ARM: dts: AM4372: Add PRCM IRQ entry Keerthy
2015-07-08 5:42 ` [PATCH v2 4/6] ARM: OMAP: PRM: Remove hardcoding of IRQENABLE_MPU_2 and IRQSTATUS_MPU_2 register offsets Keerthy
2015-07-16 2:40 ` Paul Walmsley
2015-07-08 5:42 ` [PATCH v2 5/6] ARM: OMAP4+: PRM: Add AM437x specific data Keerthy
2015-07-08 5:42 ` [PATCH v2 6/6] ARM: PRM: AM437x: Enable IO wakeup feature Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A73E3B.1010705@ti.com \
--to=a0393675@ti.com \
--cc=bcousson@baylibre.com \
--cc=galak@codeaurora.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=pawel.moll@arm.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox