From: Tang Chen <tangchen@cn.fujitsu.com>
To: Tejun Heo <tj@kernel.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
<akpm@linux-foundation.org>, <dyoung@redhat.com>,
<isimatu.yasuaki@jp.fujitsu.com>, <yasu.isimatu@gmail.com>,
<lcapitulino@redhat.com>, <qiuxishi@huawei.com>,
<will.deacon@arm.com>, <tony.luck@intel.com>,
<vladimir.murzin@arm.com>, <fabf@skynet.be>,
<kuleshovmail@gmail.com>, <bhe@redhat.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 1/1] mem-hotplug: Handle node hole when initializing numa_meminfo.
Date: Thu, 16 Jul 2015 13:30:36 +0800 [thread overview]
Message-ID: <55A7417C.6000106@cn.fujitsu.com> (raw)
In-Reply-To: <20150715212008.GK15934@mtj.duckdns.org>
On 07/16/2015 05:20 AM, Tejun Heo wrote:
> On Wed, Jul 01, 2015 at 11:16:54AM +0800, Tang Chen wrote:
> ...
>> - /* and there's no empty block */
>> - if (bi->start >= bi->end)
>> + /* and there's no empty or non-exist block */
>> + if (bi->start >= bi->end ||
>> + memblock_overlaps_region(&memblock.memory,
>> + bi->start, bi->end - bi->start) == -1)
> Ugh.... can you please change memblock_overlaps_region() to return
> bool instead?
Well, I think memblock_overlaps_region() is designed to return
the index of the region overlapping with the given region.
Maybe it had some users before.
Of course for now, it is only called by memblock_is_region_reserved().
It is OK to change the return value of memblock_overlaps_region() to bool.
But any caller of memblock_is_region_reserved() should also be changed.
I think it is OK to leave it there.
Thanks.
>
> Thanks.
>
next prev parent reply other threads:[~2015-07-16 5:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 3:16 [PATCH 1/1] mem-hotplug: Handle node hole when initializing numa_meminfo Tang Chen
2015-07-01 6:25 ` Xishi Qiu
2015-07-01 7:55 ` Tang Chen
2015-07-01 8:55 ` Xishi Qiu
2015-07-02 15:02 ` Yasuaki Ishimatsu
2015-07-03 1:26 ` Tang Chen
2015-07-06 16:42 ` Yasuaki Ishimatsu
2015-07-07 8:57 ` Tang Chen
2015-07-15 21:20 ` Tejun Heo
2015-07-16 5:30 ` Tang Chen [this message]
2015-07-16 7:21 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A7417C.6000106@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=fabf@skynet.be \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kuleshovmail@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vladimir.murzin@arm.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox