From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753368AbbGPGQ1 (ORCPT ); Thu, 16 Jul 2015 02:16:27 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:38339 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753135AbbGPGQZ (ORCPT ); Thu, 16 Jul 2015 02:16:25 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-00-55a74c36b44f Message-id: <55A74C32.9040902@samsung.com> Date: Thu, 16 Jul 2015 15:16:18 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: linux-samsung-soc@vger.kernel.org, Kevin Hilman , Arnd Bergmann , linux-kernel@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] ARM: multi_v7_defconfig: Enable max77802 regulator References: <1436977965-7078-1-git-send-email-javier@osg.samsung.com> <1436977965-7078-2-git-send-email-javier@osg.samsung.com> <55A6FEA0.8090202@samsung.com> <55A744C9.6040703@osg.samsung.com> In-reply-to: <55A744C9.6040703@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xK7pmPstDDTp32Fj8nXSM3eLN2zVM Fq9fGFr0P37NbPH18ApGi02Pr7FaXN41h81ixvl9TBanrn9mc+D0+P1rEqPHplWdbB53ru1h 89i8pN7jyokmVo8t/XfZPfq2rGL0+LxJLoAjissmJTUnsyy1SN8ugSvj3cZFLAXneSp+vF7J 3sA4g6uLkYNDQsBEou9BRhcjJ5ApJnHh3nq2LkYuDiGBpYwSbw5+YIJwnjJKnL/0jgWkildA S+LBpD/MIDaLgKrEgT3TweJsAsYSm5cvYQOxRQUiJN5ePskEUS8o8WPyPbAaEYEwibntB1lB hjILXGCU2LKxkx0kISzgLXGs5xkjxLajjBJPD+wHm8QpoC/x99cDRpBTmQX0JO5f1AIJMwvI S2xe85Z5AqPALCQ7ZiFUzUJStYCReRWjaGppckFxUnquoV5xYm5xaV66XnJ+7iZGSEx82cG4 +JjVIUYBDkYlHl6O38tChVgTy4orcw8xSnAwK4nwPvVcHirEm5JYWZValB9fVJqTWnyIUZqD RUmcd+6u9yFCAumJJanZqakFqUUwWSYOTqkGxk4L3aR9/B3Vs3pn7888bazpc25VS6bWu7TI F1GH1ydZqamK+bNJ5CsE8aou1Q/1X3twC5tm8YIruofX/12lnPiS6XjlsYBzu3U9VfedX/RL Umh/Bc9u3UWtn56tmvT14Y1L8T86IhPOM0bNTn7/lu2JT1dy2KdJPse2v/ked5izxmXHl9M1 0kosxRmJhlrMRcWJAAe1O5qFAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.07.2015 14:44, Javier Martinez Canillas wrote: > Hello Krzysztof, > > Thanks for the feedback. > > On 07/16/2015 02:45 AM, Krzysztof Kozlowski wrote: >> On 16.07.2015 01:32, Javier Martinez Canillas wrote: >>> The Maxim max77802 Power Management IC has besides other devices, a set of >>> regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 >>> regulator, rtc and clock drivers") was supposed to enable the config option >>> for the regulator driver as a module but the final version that landed did >>> not include this. So this patch enables the needed Kconfig option. >>> >>> Signed-off-by: Javier Martinez Canillas >> >> Please describe why do you want to enable it (IOW who will benefit from >> enabling it?). This symbol was removed by Kukjin from your commit: >> [kgene@kernel.org: removing useless REGULATOR_MAX77802 config] >> so justification would be welcomed. >> > > You are right, sorry for not making the commit message clear. This PMIC > is used by a couple of Exynos5 based boars such as the Peach Pit and Pi > Chromebooks. I expect it to be found in other designs too just like the > max77686 is found in many Exynos5 based boards. > > I'll add this to the commit message on v2. > >> Beside the commit description I agree with the patch. >> > > Does this mean I can add your Reviewed-by to this patch as well? With extended description (something similar to explanation in your other patches) yes, go ahead: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof