Re: [RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree_skb

Malcolm Priestley
2015-07-16T10:08:34Z

On 16/07/15 09:54, Dan Carpenter wrote:
> On Thu, Jul 16, 2015 at 08:45:06AM +0000, Maninder Singh wrote:
>> where we are checking for (pTDInfo->skb), we are using it in above line.
>> and it does not look good, thats why we should remove thse checks and i have suggested
>> changes.
>>
>> code snippet:-
>> -----------------------
>>
>> if (pTDInfo->skb_dma && (pTDInfo->skb_dma != pTDInfo->buf_dma))
> ^^^^^^^^^^^^^^^^
> This is allocated after ->skb so if ->skb_dma is non-NULL then ->skb is
> also non-NULL.
>
>> dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
>> pTDInfo->skb->len, DMA_TO_DEVICE);
>
> Is this a static checker warning? If so then it's a false positive.
>

This is old code dma_unmap_single never happens and is to be removed.

pTDInfo->skb now originates from mac80211.

I am in the process of tiding up pTDInfo that removes skb_dma.

In the past, this driver several API's sharing the same device now it
has just one.

Regards

Malcolm