Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords

[Denys Vlasenko <dvlasenk@redhat.com>]

On 07/16/2015 12:41 PM, Thomas Graf wrote:
> On 07/16/15 at 12:02pm, Denys Vlasenko wrote:
>> +/* jhash - hash an arbitrary key
>> + * @k: sequence of bytes as key
>> + * @length: the length of the key
>> + * @initval: the previous hash, or an arbitray value
>> + *
>> + * The generic version, hashes an arbitrary sequence of bytes.
>> + * No alignment or length assumptions are made about the input key.
>> + *
>> + * Returns the hash value of the key. The result depends on endianness.
>> + */
>> +u32 jhash(const void *key, u32 length, u32 initval)
> 
> Shouldn't these live in lib/jhash.c or something? Otherwise
> everyone needs to depend on CONFIG_RHASHTABLE

There is no CONFIG_RHASHTABLE, rhashtable.c is compiled unconditionally.

I will send an alternative patch, which creates jhash.c;
apply whichever version you like most.