From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756182AbbGPT0r (ORCPT ); Thu, 16 Jul 2015 15:26:47 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:36208 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753858AbbGPT0q (ORCPT ); Thu, 16 Jul 2015 15:26:46 -0400 Message-ID: <55A80505.8010009@gmail.com> Date: Thu, 16 Jul 2015 12:24:53 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Krause CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] genet:Return the variable ret rather then zero for the function bcmgenet_power_down References: <1436972983-2820-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1436972983-2820-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/07/15 08:09, Nicholas Krause wrote: > This makes the function bcmgenet_power_down return the variable ret > rather then zero in order to make this function be able to signal its > caller with a error code when a failure occurs internally rather then > always appearing to run successfully to its caller. Please adjust the subject to be "net: bcmgenet: blah blah", just to conform to the style used for all other changes. This seems fine otherwise... > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > index 64c1e9d..129e5b5 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > @@ -877,7 +877,7 @@ static int bcmgenet_power_down(struct bcmgenet_priv *priv, > break; > } > > - return 0; > + return ret; > } > > static void bcmgenet_power_up(struct bcmgenet_priv *priv, > -- Florian