From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756298AbbGPThW (ORCPT ); Thu, 16 Jul 2015 15:37:22 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:35902 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbbGPThV (ORCPT ); Thu, 16 Jul 2015 15:37:21 -0400 Message-ID: <55A80782.9050907@gmail.com> Date: Thu, 16 Jul 2015 12:35:30 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Krause CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net:bcmgent:Return the variable ret rather then zero for the function bcmgenet_power_down References: <1437075256-21395-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1437075256-21395-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/07/15 12:34, Nicholas Krause wrote: > This makes the function bcmgenet_power_down return the variable ret > rather then zero in order to make this function be able to signal its > caller with a error code when a failure occurs internally rather then > always appearing to run successfully to its caller. Still not quite the right subject (missing spaces, typos), copy/paste this: net: bcmgenet: Return the variable ret rather then zero for the function bcmgenet_power_down > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > index 64c1e9d..129e5b5 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > @@ -877,7 +877,7 @@ static int bcmgenet_power_down(struct bcmgenet_priv *priv, > break; > } > > - return 0; > + return ret; > } > > static void bcmgenet_power_up(struct bcmgenet_priv *priv, > -- Florian