From: "Wangnan (F)" <wangnan0@huawei.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kaixu xia <xiakaixu@huawei.com>, <ast@plumgrid.com>,
<davem@davemloft.net>, <acme@kernel.org>, <mingo@redhat.com>,
<masami.hiramatsu.pt@hitachi.com>, <jolsa@kernel.org>,
<linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
<hekuang@huawei.com>
Subject: Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map
Date: Fri, 17 Jul 2015 20:07:13 +0800 [thread overview]
Message-ID: <55A8EFF1.3050005@huawei.com> (raw)
In-Reply-To: <20150717120206.GG19282@twins.programming.kicks-ass.net>
On 2015/7/17 20:02, Peter Zijlstra wrote:
> On Fri, Jul 17, 2015 at 07:54:55PM +0800, Wangnan (F) wrote:
>> Thanks. In next version we will introduce a new function which do oppsite
>> thing to
>> perf_event_release_kernel() in perf/event/core.c, then fetch the event
>> before fdput.
> perf_event_get() as proposed, with the addition of the refcount
> increment inside the fdget/fdput() is fine.
>
> Note that the _get() name already implies a refcount increment.
OK, you'll see it in v2.
Thank you.
next prev parent reply other threads:[~2015-07-17 12:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 10:43 [RFC PATCH 0/6] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter kaixu xia
2015-07-17 10:43 ` [RFC PATCH 1/6] bpf: Add new flags that specify the value type stored in map kaixu xia
2015-07-17 10:43 ` [RFC PATCH 2/6] bpf: Add function map->ops->map_traverse_elem() to traverse map elems kaixu xia
2015-07-17 10:43 ` [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map kaixu xia
2015-07-17 11:06 ` Peter Zijlstra
2015-07-17 11:21 ` Wangnan (F)
2015-07-17 11:34 ` Wangnan (F)
2015-07-17 11:40 ` Peter Zijlstra
2015-07-17 11:54 ` Wangnan (F)
2015-07-17 12:02 ` Peter Zijlstra
2015-07-17 12:07 ` Wangnan (F) [this message]
2015-07-17 11:37 ` Peter Zijlstra
2015-07-17 10:43 ` [RFC PATCH 4/6] bpf: Add a bpf program function argument constraint for PMU map kaixu xia
2015-07-17 10:43 ` [RFC PATCH 5/6] bpf: Implement function bpf_read_pmu() that get the selected hardware PMU conuter kaixu xia
2015-07-17 11:05 ` Peter Zijlstra
2015-07-17 11:29 ` Wangnan (F)
2015-07-17 11:39 ` Peter Zijlstra
2015-07-17 11:45 ` Wangnan (F)
2015-07-17 11:55 ` Peter Zijlstra
2015-07-17 11:56 ` Peter Zijlstra
2015-07-17 12:01 ` Wangnan (F)
2015-07-17 12:04 ` Wangnan (F)
2015-07-17 12:18 ` Peter Zijlstra
2015-07-17 12:27 ` Wangnan (F)
2015-07-17 12:45 ` Peter Zijlstra
2015-07-17 12:46 ` Peter Zijlstra
2015-07-17 12:57 ` pi3orama
2015-07-17 13:26 ` Peter Zijlstra
2015-07-17 13:45 ` pi3orama
2015-07-17 11:33 ` Peter Zijlstra
2015-07-17 10:43 ` [RFC PATCH 6/6] samples/bpf: example of get selected PMU counter value kaixu xia
2015-07-17 22:56 ` [RFC PATCH 0/6] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter Alexei Starovoitov
2015-07-17 23:27 ` pi3orama
2015-07-18 0:42 ` Alexei Starovoitov
2015-07-18 1:02 ` pi3orama
2015-07-18 1:22 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8EFF1.3050005@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pi3orama@163.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox