From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbbGQRKR (ORCPT ); Fri, 17 Jul 2015 13:10:17 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34291 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbbGQRKO (ORCPT ); Fri, 17 Jul 2015 13:10:14 -0400 Message-ID: <55A9367D.6040001@gmail.com> Date: Fri, 17 Jul 2015 10:08:13 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Krause CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bcmsysport:Fix error handling in the function bcm_sysport_init_rx_ring References: <1437135231-27511-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1437135231-27511-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/07/15 05:13, Nicholas Krause wrote: > This fixes the error handling in the function bcm_sysport_init_rx_ringi > after calling the function rdma_enable_set to make sure the return value > is equal to zero and if not print on the console failed to enable RDMA > for the device and return the failed error code returned by > rdma_enable_set. Subject should be starting with "net: systemport: ", otherwise, this looks good to me: Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/broadcom/bcmsysport.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c > index 4566cdf..27a7b36 100644 > --- a/drivers/net/ethernet/broadcom/bcmsysport.c > +++ b/drivers/net/ethernet/broadcom/bcmsysport.c > @@ -1365,7 +1365,12 @@ static int bcm_sysport_init_rx_ring(struct bcm_sysport_priv *priv) > /* Initialize HW, ensure RDMA is disabled */ > reg = rdma_readl(priv, RDMA_STATUS); > if (!(reg & RDMA_DISABLED)) > - rdma_enable_set(priv, 0); > + ret = rdma_enable_set(priv, 0); > + > + if (ret) { > + netif_err(priv, hw, priv->netdev, "failed to enable RDMA\n"); > + return ret; > + } > > rdma_writel(priv, 0, RDMA_WRITE_PTR_LO); > rdma_writel(priv, 0, RDMA_WRITE_PTR_HI); > -- Florian