From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, sudipm.mukherjee@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/23] staging: rtl8192e: Various cleanups
Date: Fri, 17 Jul 2015 21:52:10 +0200 [thread overview]
Message-ID: <55A95CEA.3020901@gmail.com> (raw)
In-Reply-To: <20150716095800.GH5835@mwanda>
On 16.07.2015 11:58, Dan Carpenter wrote:
> On Tue, Jul 14, 2015 at 10:04:03PM +0200, Mateusz Kulikowski wrote:
>> This series does some more cleanup for driver.
>>
>> Changes in V2:
>> - Added patch 6/23 (Remove rtllib_stats structure as suggested by Dan)
>> - Updated patch 22/23 (remove whitespace - hint by Sudip)
>> - Rebased into current staging next (6fdb302c)
>> - Retested
>
> Was there really a need to redo this patch? The things that Sudip and I
> mentioned could have been done in follow on patches.
>
> It's slightly easier for me to just review the follow on patches instead
> of looking at a whole patchset.
Ok, I'll keep that in mind for next patches.
Regards,
Mateusz
prev parent reply other threads:[~2015-07-17 19:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 20:04 [PATCH v2 00/23] staging: rtl8192e: Various cleanups Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 01/23] staging: rtl8192e: Remove ToLegalChannel() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 02/23] staging: rtl8192e: Remove unused defines Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 03/23] staging: rtl8192e: Remove undefs Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 04/23] staging: rtl8192e: Remove unused enums Mateusz Kulikowski
2015-07-15 6:34 ` Jakub Sitnicki
2015-07-15 7:05 ` Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 05/23] staging: rtl8192e: Remove unused fields from rtllib_stats Mateusz Kulikowski
2015-07-15 4:57 ` Sudip Mukherjee
2015-07-15 4:58 ` Sudip Mukherjee
2015-07-14 20:04 ` [PATCH v2 06/23] staging: rtl8192e: Remove rtllib_stats structure Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 07/23] staging: rtl8192e: Remove unused ether_header structure Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 08/23] staging: rtl8192e: Remove unused rtllib_device::freq_band Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 09/23] staging: rtl8192e: Remove DOT11D_GetMaxTxPwrInDbm() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 10/23] staging: rtl8192e: Remove read|write_nic_io_(d)word|byte() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 11/23] staging: rtl8192e: Remove DMESG macro Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 12/23] staging: rtl8192e: Remove rtl819x_process_cck_rxpathsel() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 13/23] staging: rtl8192e: probe: Remove bdma64 check Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 14/23] staging: rtl8192e: Remove rtl8192_rx_cmd() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 15/23] staging: rtl8192e: rtl_dm: Make functions static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 16/23] staging: rtl8192e: rtllib_HTProc: " Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 17/23] staging: rtl8192e: Make phy_RF8256_Config_ParaFile() static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 18/23] staging: rtl8192e: rtl_core: Make functions static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 19/23] staging: rtl8192e: r8192e_phy: " Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 20/23] staging: rtl8192e: Make rtl8192_QueryIsShort() static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 21/23] staging: rtl8192e: rtllib_tx: Make functions static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 22/23] staging: rtl8192e: Make rtllib_rx_mgt() static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 23/23] staging: rtl8192e: rtllib_softmac: Make functions static Mateusz Kulikowski
2015-07-16 9:58 ` [PATCH v2 00/23] staging: rtl8192e: Various cleanups Dan Carpenter
2015-07-17 19:52 ` Mateusz Kulikowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A95CEA.3020901@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox