public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] ibmvscsi:Fix comment about return values for the function ibmvfc_target_alloc
       [not found] <1436472994-31885-1-git-send-email-xerofoify@gmail.com>
@ 2015-07-17 21:13 ` Tyrel Datwyler
  0 siblings, 0 replies; only message in thread
From: Tyrel Datwyler @ 2015-07-17 21:13 UTC (permalink / raw)
  To: Nicholas Krause; +Cc: JBottomley, linux-scsi, linux-kernel

On 07/09/2015 01:16 PM, Nicholas Krause wrote:
> This fixes the comment about return values for the function
> ibmvfc_target_alloc to correctly state it only returns zero
> as it always runs successfully and therefore never signals
> its caller with the error code -ENXIO due to this exact
> reasoning.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>

Again, just a nit on the patch description wording. Something like the
following would suffice.

"Remove mention of -ENXIO from comment on return values for
ibmvfc_slave_alloc() as the function currently always returns 0."

Otherwise,

Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>

> ---
>  drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 057d277..55f161b 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -2854,7 +2854,7 @@ static int ibmvfc_slave_alloc(struct scsi_device *sdev)
>   * expected.
>   *
>   * Returns:
> - *	0 on success / -ENXIO if device does not exist
> + *	0 on success
>   **/
>  static int ibmvfc_target_alloc(struct scsi_target *starget)
>  {
> 


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-07-17 21:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1436472994-31885-1-git-send-email-xerofoify@gmail.com>
2015-07-17 21:13 ` [PATCH] ibmvscsi:Fix comment about return values for the function ibmvfc_target_alloc Tyrel Datwyler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox