From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbbGQVNu (ORCPT ); Fri, 17 Jul 2015 17:13:50 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:35046 "EHLO e19.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbbGQVNs (ORCPT ); Fri, 17 Jul 2015 17:13:48 -0400 X-Helo: d01dlp02.pok.ibm.com X-MailFrom: tyreld@linux.vnet.ibm.com X-RcptTo: linux-scsi@vger.kernel.org Message-ID: <55A97007.4040605@linux.vnet.ibm.com> Date: Fri, 17 Jul 2015 14:13:43 -0700 From: Tyrel Datwyler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Krause CC: JBottomley@odin.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ibmvscsi:Fix comment about return values for the function ibmvfc_target_alloc References: <1436472994-31885-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1436472994-31885-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071721-0057-0000-0000-000000C63E5D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2015 01:16 PM, Nicholas Krause wrote: > This fixes the comment about return values for the function > ibmvfc_target_alloc to correctly state it only returns zero > as it always runs successfully and therefore never signals > its caller with the error code -ENXIO due to this exact > reasoning. > > Signed-off-by: Nicholas Krause Again, just a nit on the patch description wording. Something like the following would suffice. "Remove mention of -ENXIO from comment on return values for ibmvfc_slave_alloc() as the function currently always returns 0." Otherwise, Acked-by: Tyrel Datwyler > --- > drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index 057d277..55f161b 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -2854,7 +2854,7 @@ static int ibmvfc_slave_alloc(struct scsi_device *sdev) > * expected. > * > * Returns: > - * 0 on success / -ENXIO if device does not exist > + * 0 on success > **/ > static int ibmvfc_target_alloc(struct scsi_target *starget) > { >