From: Stephen Warren <swarren@wwwdotorg.org>
To: Andrey Danin <danindrey@mail.ru>
Cc: devicetree@vger.kernel.org, devel@linuxdriverproject.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
ac100@lists.launchpad.net, Laxman Dewangan <ldewangan@nvidia.com>,
Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julian Andres Klode <jak@jak-linux.org>,
Marc Dietrich <marvin24@gmx.de>
Subject: Re: [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver
Date: Mon, 20 Jul 2015 16:18:11 -0600 [thread overview]
Message-ID: <55AD73A3.6000706@wwwdotorg.org> (raw)
In-Reply-To: <1437424546-30405-3-git-send-email-danindrey@mail.ru>
On 07/20/2015 02:35 PM, Andrey Danin wrote:
> Remove i2c controller related code and use tegra i2c driver in slave mode.
> Update nvec documentation.
> diff --git a/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt b/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt
I would expect this patch to add a new binding file
nvidia,nvec-slave.txt so that the filename continues to match the
compatible value it documents. This patch introduces a new binding for
the NVEC slave as opposed to modifying the existing binding.
> +- compatible : should be "nvidia,nvec-slave".
> +- reg: the i2c address of the slave controller
I think "the I2C address to respond to" would be clearer? You might also
mention that this needs to include flags from <dt-bindings/i2c/ic2.h>.
next prev parent reply other threads:[~2015-07-20 22:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 20:35 [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
2015-07-20 20:35 ` [PATCH v3 1/4] i2c: tegra: implement slave mode Andrey Danin
2015-07-24 9:27 ` Wolfram Sang
2015-07-24 10:18 ` Andrey Danin
2015-07-24 10:52 ` Wolfram Sang
2015-08-20 12:14 ` Andrey Danin
2015-09-08 11:46 ` Wolfram Sang
2015-09-08 12:31 ` Andrey Danin
2015-07-20 20:35 ` [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver Andrey Danin
2015-07-20 22:18 ` Stephen Warren [this message]
2015-07-20 20:35 ` [PATCH v3 3/4] staging/nvec: remove old code Andrey Danin
2015-07-20 20:35 ` [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus Andrey Danin
2015-07-20 22:19 ` Stephen Warren
2015-07-21 6:35 ` Andrey Danin
2015-07-21 8:25 ` Marc Dietrich
2015-07-21 8:51 ` Andrey Danin
2015-07-21 11:57 ` Marc Dietrich
2015-07-21 20:52 ` Wolfram Sang
2015-07-21 8:38 ` [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD73A3.6000706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ac100@lists.launchpad.net \
--cc=danindrey@mail.ru \
--cc=devel@linuxdriverproject.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jak@jak-linux.org \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=marvin24@gmx.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox